Skip to contentSkip to conversation

New: found overlapping data buffer

Bug 13437 [email protected] 1 participant 6 messages Jun 3, 2009 – Jun 18, 2009 SCSI

lore
Share & tools
lore
#0 lore raw

http://bugzilla.kernel.org/show_bug.cgi?id=13437

Summary: found overlapping data buffer
Product: SCSI Drivers
Version: 2.5
Kernel Version: 2.6.29.3
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: GDT SCSI
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

Hello,

i detected an overlapping data buffer at file "linux-2.6.29.3/drivers/scsi/gdth_proc.c"
For detection, i used the static code analysis tool cppcheck. It prints the following message:
[linux-2.6.29.3/drivers/scsi/gdth_proc.c:199]: (error) Overlapping data buffer hrec

Take a loop at file gdth_proc.c at line 199:

            sprintf(hrec,"%s,%d", hrec, reserve_list[i]);

Here, hrec is used by iteself at the sprintf statement, this is dangerous!!!!

Best regards

Ettl Martin

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#1 lore raw

[Bug 13437] found overlapping data buffer

http://bugzilla.kernel.org/show_bug.cgi?id=13437

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
         Resolution|                            |CODE_FIX
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#2 lore raw

[Bug 13437] found overlapping data buffer

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=13437

Marc Bejarano <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

                 CC|                            |[email protected]
                   |                            |g

--- Comment #1 from Marc Bejarano <[email protected]> 2009-06-18 03:09:24 ---
alan: have a commit id for the fix handy?

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#4 lore raw

[Bug 13437] found overlapping data buffer

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=13437

Martin Ettl <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|RESOLVED                    |CLOSED
         Resolution|CODE_FIX                    |PATCH_ALREADY_AVAILABLE

--- Comment #3 from Martin Ettl <[email protected]> 2009-06-18 07:57:41 --- To my mind, this can be closed here.

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#5 lore raw

[Bug 13437] found overlapping data buffer

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=13437

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|PATCH_ALREADY_AVAILABLE |CODE_FIX

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.