Skip to contentSkip to conversation

USB storage: "No sense [current]" when connecting

Bug 14118 [email protected] 1 participant 8 messages Sep 5, 2009 – Oct 27, 2009 1 message not in the archive SCSI

lore
Share & tools
lore

[email protected]

author
#1 lore raw
In reply to a message not in the archive

http://bugzilla.kernel.org/show_bug.cgi?id=14118

Andrew Morton <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

          Component|USB                         |SCSI
         AssignedTo|[email protected]              |[email protected]
            Product|Drivers                     |IO/Storage
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
author
#2 lore raw
In reply to a message not in the archive

http://bugzilla.kernel.org/show_bug.cgi?id=14118

--- Comment #7 from Andrew Morton <[email protected]> 2009-09-05 20:53:45 ---

Quoted 8 lines · On Sat, 5 Sep 2009 16:40:06 -0400 (EDT) Alan Stern <[email protected]>…
Quoted 6 lines
Quoted 4 lines

The second problem has nothing to do with USB; it is a bug in the SCSI layer. If the module parameter doesn't fix everything, I suggest this bug report be reassigned to James Bottomley rather than Greg Kroah-Hartman and the component be changed from USB to SCSI.

Should I edit the bug myself? (If yes, what address do I reassign it to?)

Maybe we can prevail upon Andrew Morton to reassign it for you.

OK, I reassigned it to scsi, but I expect it would help the scsi guys if someone could add a new summary of what they think the actual bug is.

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
author
#3 lore raw
In reply to a message not in the archive

http://bugzilla.kernel.org/show_bug.cgi?id=14118

--- Comment #8 from Alan Stern <[email protected]> 2009-09-05 21:18:18 ---

Quoted 2 lines · Andrew Morton

OK, I reassigned it to scsi, but I expect it would help the scsi guys if someone could add a new summary of what they think the actual bug is.

Okay, here's a quick summary. This USB mass storage device has a bug:
It doesn't like to access the last 16 or so sectors of LUN 0. When asked to read from those sectors it returns no data and Check Condition set. Then in response to REQUEST SENSE it returns no information (SK=0, ASC=ASCQ=0).

This causes the SCSI midlayer to reissue the read request, with the same result. We enter an unending loop because each READ is a new request with a new timeout. That's the real problem -- the bug in the phone wouldn't matter much if SCSI would just give up and fail the READ after a couple of retries.

There are a few more details in comment #4. Note that recently people have been encountering more and more devices with this same kind of bug (READ fails, REQUEST SENSE returns nothing).

My suggestion for a fix: Don't call scsi_requeue_command() if the current command made zero forward progress. But this will have to be elaborated and made reliable.

Alan Stern

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
author
#4 lore raw
In reply to a message not in the archive

http://bugzilla.kernel.org/show_bug.cgi?id=14118

--- Comment #9 from Alan Stern <[email protected]> 2009-09-28 18:01:16 --- Created an attachment (id=23196)
--> (http://bugzilla.kernel.org/attachment.cgi?id=23196)
Patch to handle errors with no sense

Try this patch. It should fix the problem of the unending retries. There will still be errors, but each one will be retried only a small number of times.

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
author
#5 lore raw
In reply to a message not in the archive

http://bugzilla.kernel.org/show_bug.cgi?id=14118

--- Comment #10 from Mantas Mikulėnas <[email protected]> 2009-10-03 20:19:36 ---

Quoted 2 lines

Try this patch. It should fix the problem of the unending retries. There will still be errors, but each one will be retried only a small number of times.

The patch seems to fix the problems.

(Tried with 2.6.31.1 kernel, default Arch Linux configuration, if that matters.)

Signature · 6 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#7 lore raw
In reply to a message not in the archive

http://bugzilla.kernel.org/show_bug.cgi?id=14118

--- Comment #12 from Alan Stern <[email protected]> 2009-10-13 02:40:33 --- The patch has been merged as commit f1a0743bc0e7a30c032b1eb78f6a2b0f805b4597. You can close out this bug report.

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
author
#8 lore raw
In reply to a message not in the archive

http://bugzilla.kernel.org/show_bug.cgi?id=14118

Mantas Mikulėnas <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |CODE_FIX
Signature · 6 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html