ice: no way to disable lsc-interrupts
[email protected]
Acked-by Qiming Yanghttps://bugs.dpdk.org/show_bug.cgi?id=1418
Bug ID: 1418
Summary: ice: no way to disable lsc-interrupts
Product: DPDK
Version: 24.03
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: other
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]Target Milestone: ---
Hi all,
Apparently, the ice driver does not allow disabling lsc interrupts. Starting testpmd with --no-lsc-interrupt gives this in the console:
testpmd> ice_interrupt_handler(): OICR: link state change event Port 0: link state change event ice_interrupt_handler(): OICR: link state change event Port 1: link state change event
I tested with version 22.11 which seems not to have the issue. I found a suspicious commit introduced in 24.03 which may be the culprit:
commit 4e5dc111464e83e9a55fa466d8f682f0027b721e
Author: Qi Zhang <[email protected]> Date: Thu Dec 14 03:40:54 2023 -0500
net/ice: fix link update
The ice_aq_get_link_info function is not thread-safe. However, it is possible to simultaneous invocations during both the dev_start and the LSC interrupt handler, potentially leading to unexpected adminq errors. This patch addresses the issue by introducing a thread-safe wrapper that utilizes a spinlock.
https://git.dpdk.org/dpdk/commit/?id=4e5dc111464e83e9a55fa466d8f682f0027b721e
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.