Skip to contentSkip to conversation

New: Hibernation oopses for the 2nd time with 2.6.31 (won't fit the screen)

Bugme-new Andrew Morton 1 participant 1 message Sep 24, 2009 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 17 lines · On Thu, 24 Sep 2009 14:07:09 GMT [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=14222

Summary: Hibernation oopses for the 2nd time with 2.6.31 (won't
fit the screen)
Product: Timers
Version: 2.5
Kernel Version: 2.6.31
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: Yes

It's a 2.6.21 regression.

Quoted 9 lines

Hibernation worked great with 2.6.30 - I had over a month of uptime (it never worked so well before - always crashed after some time). But in 2.6.31, it's broken again - and completely. The first hibernation works but it always crashes on the second one.

The oops won't fit the screen, even 1280x1024 is not enough.

I bisected it and found this:

Thanks for bisecting it.

Quoted 19 lines

c7121843685de2bf7f3afd3ae1d6a146010bf1fc is first bad commit commit c7121843685de2bf7f3afd3ae1d6a146010bf1fc
Author: Magnus Damm <[email protected]>
Date: __ Tue Jul 28 14:09:55 2009 -0700

__ __ clocksource: Save mult_orig in clocksource_disable()

__ __ To fix the common case where ->enable() does not set up __ __ mult, make sure mult_orig is saved in mult on disable.

__ __ Also add comments to explain why we do this.

__ __ Signed-off-by: Magnus Damm <[email protected]>
__ __ Cc: [email protected]
__ __ Cc: [email protected]
__ __ Cc: [email protected]
__ __ LKML-Reference: <[email protected]> __ __ Signed-off-by: Thomas Gleixner <[email protected]>

Quoted 4 lines

:040000 040000 c965062bc79af46cdb3522fc7ab1cc81d2f84de3 26616c88a8128b25fd15c3da39ac6251cd9723b6 M __ __ __include

Reverting this commit fixes the problem.

OK, I cc'ed everyone.

Guys, is reverting this patch the best approach?

It might be for 2.6.31.x but not for 2.6.32, perhaps?