sysctl: fix false positives when PROC_SYSCTL=n
A message that is not in the archive (sent off-list or not yet received): [email protected]/
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 sysctl: fix false positives when PROC_SYSCTL=n
Having ->procname but not ->proc_handler is valid when PROC_SYSCTL=n, people use such combination to reduce ifdefs with non-standard handlers.
http://bugzilla.kernel.org/show_bug.cgi?id=14408
---
kernel/sysctl_check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sysctl_check.c +1 -1
@@ -1521,7 +1521,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)if (!table->ctl_name && table->strategy)set_fail (&fail, table,"Strategy without ctl_name" );#endif -#ifdef CONFIG_PROC_FS +#ifdef CONFIG_PROC_SYSCTL if (table->procname && !table->proc_handler)set_fail (&fail, table,"No proc_handler" );#endif
Quoted 4 lines · Alexey Dobriyan
Having ->procname but not ->proc_handler is valid when PROC_SYSCTL=n, people use such combination to reduce ifdefs with non-standard handlers.
It looks like I messed up when I wrote sysctl_check.c and used the wrong ifdef. Silly me. Especially since I had added PROC_SYSCTL earlier.
Eric
Quoted 17 lines
Signed-off-by Alexey Dobriyan <[email protected]>---
kernel/sysctl_check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/sysctl_check.c +1
-1@@ -1521,7 +1521,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)if (!table->ctl_name && table->strategy)set_fail (&fail, table,"Strategy without ctl_name" );#endif -#ifdef CONFIG_PROC_FS +#ifdef CONFIG_PROC_SYSCTL if (table->procname && !table->proc_handler)set_fail (&fail, table,"No proc_handler" );#endif