Skip to contentSkip to conversation

New: nodejs won't build on Fedora 35

Buildroot In review [email protected] 5 participants 12 messages Dec 13, 2021 – Jan 9, 2022 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=14451

            Bug ID: 14451
           Summary: nodejs won't build on Fedora 35
           Product: buildroot
           Version: 2021.08
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]

Target Milestone: ---

Although I'm using host-python, the nodejs build cycle uses at some point the system python instead of the host python.

On Fedora 35 this is Python 3.10, causing problems. Switching to Python 3.9 system-wide fixes the issue.

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

[Buildroot] [Bug 14451] nodejs won't build on Fedora 35

https://bugs.busybox.net/show_bug.cgi?id=14451

--- Comment #1 from Vincent Fazio <[email protected]> --- Certain parts of the build invoke "python" and aren't using a full path to the bin to do so. While PATH has been set to include the host built python3 and PYTHON is set to host-python3 built bin, the build process is not respecting that. We do not have a symlink python -> python3 (afaik most distros do not include python by default, just python3) so when the build stage gets invoked it's using the "python" available from PATH

LD_LIBRARY_PATH=/mnt/development/buildroot/output/build/nodejs-14.18.1/out/Release/lib.host:/mnt/development/buildroot/output/build/nodejs-14.18.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../tools/v8_gypfiles; mkdir -p /mnt/development/buildroot/output/build/nodejs-14.18.1/out/Release/obj/gen/generate-bytecode-output-root/builtins-generated;
python ../../deps/v8/tools/run.py
"/mnt/development/buildroot/output/build/nodejs-14.18.1/out/Release/v8-qemu-wrapper" "/mnt/development/buildroot/output/build/nodejs-14.18.1/out/Release/bytecode_builtins_list_generator" "/mnt/development/buildroot/output/build/nodejs-14.18.1/out/Release/obj/gen/generate-bytecode-output-root/builtins-generated/bytecodes-builtins-list.h"

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

[Buildroot] [Bug 14451] nodejs won't build on Fedora 35

In reply to [email protected]

https://bugs.busybox.net/show_bug.cgi?id=14451

--- Comment #2 from Arnout Vandecappelle <[email protected]> --- We can use the same approach as in qt5webkit:

# QtWebkit's build system uses python, but only supports python2. We work

# around this by forcing python2 early in the PATH, via a python->python2
# symlink.
QT5WEBKIT_CONF_ENV = PATH=$(@D)/host-bin:$(BR_PATH)
QT5WEBKIT_MAKE_ENV = PATH=$(@D)/host-bin:$(BR_PATH)
define QT5WEBKIT_PYTHON2_SYMLINK
        mkdir -p $(@D)/host-bin
        ln -sf $(HOST_DIR)/bin/python2 $(@D)/host-bin/python
endef
QT5WEBKIT_PRE_CONFIGURE_HOOKS += QT5WEBKIT_PYTHON2_SYMLINK
Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

PATCH 1/1 package/mesa3d: don't disable DRI3 for some Gallium drivers

Certain Gallium drivers need DRI3 support, otherwise opengl won't work. On the Raspberry Pi 4, for example, glxgears will complain about

'Failed to open bo 1: permission denied'

These drivers must not be selected to disable DRI3 support. It seems to be the same for Lima and Panfrost, please check bug 13831.

---
 package/mesa3d/mesa3d.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/mesa3d/mesa3d.mk +5 -1
index 61b095ccca..9780d5a960 100644
@@ -121,7 +121,11 @@ MESA3D_CONF_OPTS += \
        -Dgallium-extra-hud=true
 endif
 
-ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),)
+ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_LIMA) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_PANFROST),)
 MESA3D_CONF_OPTS += \
        -Ddri-drivers= -Ddri3=disabled
 else
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH 1/1] package/mesa3d: don't disable DRI3 for some Gallium drivers

Hi Michael,

Quoted 18 lines · Michael Taubert

Certain Gallium drivers need DRI3 support, otherwise opengl won't work. On the Raspberry Pi 4, for example, glxgears will complain about

'Failed to open bo 1: permission denied'

These drivers must not be selected to disable DRI3 support. It seems to be the same for Lima and Panfrost, please check bug 13831.

---
  package/mesa3d/mesa3d.mk | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)
package/mesa3d/mesa3d.mk +0 -0
index 61b095ccca..9780d5a960 100644

package/mesa3d/mesa3d.mk MESA3D_CONF_OPTS += \ · line 128

Quoted 9 lines
package/mesa3d/mesa3d.mk +5 -1
@@ -121,7 +121,11 @@ MESA3D_CONF_OPTS += \
         -Dgallium-extra-hud=true
  endif
 
-ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),)
+ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_LIMA) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_PANFROST),)

The mesa3d stuff goes way over my head, actually, but I would think that the
proper solution here would be that these configs select BR2_PACKAGE_MESA3D_DRI_DRIVER.

I know it sounds weird that a gallium driver is also a DRI driver, but I guess
that's what it is...

Bernd, can you comment?

Regards,
Arnout

package/mesa3d/mesa3d.mk MESA3D_CONF_OPTS += \ · line 131

Quoted 3 lines
package/mesa3d/mesa3d.mk +0 -0
  MESA3D_CONF_OPTS += \
         -Ddri-drivers= -Ddri3=disabled
  else

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#7 lore raw

Re: [Buildroot] [PATCH 1/1] package/mesa3d: don't disable DRI3 for some Gallium drivers

In reply to a message not in the archive

Am Thu, 16 Dec 2021 18:28:56 +0100 schrieb Arnout Vandecappelle:

Quoted 1 line

Bernd, can you comment?

Hi Arnout,

no, because I do not use buildroot on rbpi hardware.

But the topic was already discussed this summer, with no solution afaics:
https://patchwork.ozlabs.org/project/buildroot/list/?
series=248555&submitter=&state=*&q=&archive=&delegate=

Regards, Bernd

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Re: [Buildroot] [PATCH 1/1] package/mesa3d: don't disable DRI3 for some Gallium drivers

In reply to Arnout Vandecappelle

Hi Arnout,

I'm not that familiar with these configs, yet. But if I understand it right, your advice is to have the selection of these Gallium drivers should also select BR2_PACKAGE_MESA3D_DRI_DRIVER.

I will have a look on how to do that tomorrow and provide another patch then.

Kind regards,
Michael

Am 16.12.2021 um 18:28 schrieb Arnout Vandecappelle:

Quoted 34 lines

 Hi Michael,

Quoted 21 lines · Michael Taubert

Certain Gallium drivers need DRI3 support, otherwise opengl won't work. On the Raspberry Pi 4, for example, glxgears will complain about

'Failed to open bo 1: permission denied'

These drivers must not be selected to disable DRI3 support. It seems to be the same for Lima and Panfrost, please check bug 13831.

---
  package/mesa3d/mesa3d.mk | 6 +++++-

  1 file changed, 5 insertions(+), 1 deletion(-)
package/mesa3d/mesa3d.mk +0 -0
index 61b095ccca..9780d5a960 100644
@@ -121,7 +121,11 @@ MESA3D_CONF_OPTS += \

         -Dgallium-extra-hud=true
  endif

package/mesa3d/mesa3d.mk MESA3D_CONF_OPTS += \ · line 128

Quoted 6 lines
package/mesa3d/mesa3d.mk +5 -1
-ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),)
+ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_LIMA) \
+       $(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_PANFROST),)

 The mesa3d stuff goes way over my head, actually, but I would think
that the proper solution here would be that these configs select BR2_PACKAGE_MESA3D_DRI_DRIVER.

Quoted 11 lines

 I know it sounds weird that a gallium driver is also a DRI driver, but
I guess that's what it is...

 Bernd, can you comment?

 Regards,
 Arnout

Quoted 3 lines

  MESA3D_CONF_OPTS += \
         -Ddri-drivers= -Ddri3=disabled
  else

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#8 lore raw

Re: [Buildroot] [PATCH 1/1] package/mesa3d: don't disable DRI3 for some Gallium drivers

In reply to Bernd Kuhls
Quoted 11 lines · Bernd Kuhls

Am Thu, 16 Dec 2021 18:28:56 +0100 schrieb Arnout Vandecappelle:

Quoted 1 line

Bernd, can you comment?

Hi Arnout,

no, because I do not use buildroot on rbpi hardware.

But the topic was already discussed this summer, with no solution afaics:
https://patchwork.ozlabs.org/project/buildroot/list/?
series=248555&submitter=&state=*&q=&archive=&delegate=

Good find, thanks!

Michael, can you try that patch [1] and see if it works for you?

Peter, I think I'm just going to apply []] except that I'll make
BR2_PACKAGE_MESA3D_DRI3 a blind option (i.e. not user visible, only selected automatically by the drivers, much like BR2_PACKAGE_MESA3D_DRI).

My other major comment about that patch was that I suspected that it would
need some 'select' statements, but I guess the autobuilders will inform us of that, so we can go ahead and merge it.

Does that sound OK to you?

Regards,
Arnout

[1] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 8 lines

Regards, Bernd

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#9 lore raw

Re: [Buildroot] [PATCH 1/1] package/mesa3d: don't disable DRI3 for some Gallium drivers

Hello Arnout, *,

Quoted 21 lines · Arnout Vandecappelle
Quoted 11 lines · Bernd Kuhls

Am Thu, 16 Dec 2021 18:28:56 +0100 schrieb Arnout Vandecappelle:

Quoted 1 line

Bernd, can you comment?

Hi Arnout,

no, because I do not use buildroot on rbpi hardware.

But the topic was already discussed this summer, with no solution afaics:
https://patchwork.ozlabs.org/project/buildroot/list/?
series=248555&submitter=&state=*&q=&archive=&delegate=

Good find, thanks!

Michael, can you try that patch [1] and see if it works for you?

Peter, I think I'm just going to apply []] except that I'll make
BR2_PACKAGE_MESA3D_DRI3 a blind option (i.e. not user visible, only selected automatically by the drivers, much like BR2_PACKAGE_MESA3D_DRI).

Quoted 5 lines

My other major comment about that patch was that I suspected that it would
need some 'select' statements, but I guess the autobuilders will inform us of that, so we can go ahead and merge it.

Does that sound OK to you?

Fine with me ;-)

Regards,
Peter

Quoted 17 lines

Regards,
Arnout

[1]
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 8 lines

Regards, Bernd

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#10 lore raw

Re: [Buildroot] [PATCH 1/1] package/mesa3d: don't disable DRI3 for some Gallium drivers

In reply to Arnout Vandecappelle

Hi!

I've applied the patch to the latest origin/master. One hunk has been rejected:

mesa3d/Config.in +2 -0
@@ -70,6 +75,8 @@  config BR2_PACKAGE_MESA3D_DRI_DRIVER
                !BR2_PACKAGE_MESA3D_OPENGL_GLX && \
                !BR2_PACKAGE_MESA3D_OPENGL_EGL && \
                !BR2_PACKAGE_MESA3D_OSMESA_GALLIUM
+       select BR2_PACKAGE_MESA3D_DRI3 if \
+               (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4)
        select BR2_PACKAGE_XLIB_LIBXSHMFENCE if \
                (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4)
 

But it looks good for me anyway. I've tried by using raspberrypi_64_defconfig and only enabled mesa3d with Gallium drivers for V3D and VC4.

According to the build log, it has been compiled with DRI3 support.

Regards,
Michael

Am 12/16/21 um 7:33 PM schrieb Arnout Vandecappelle:

Quoted 43 lines · Bernd Kuhls
Quoted 11 lines

Am Thu, 16 Dec 2021 18:28:56 +0100 schrieb Arnout Vandecappelle:

Quoted 1 line

   Bernd, can you comment?

Hi Arnout,

no, because I do not use buildroot on rbpi hardware.

But the topic was already discussed this summer, with no solution afaics:
https://patchwork.ozlabs.org/project/buildroot/list/?
series=248555&submitter=&state=*&q=&archive=&delegate=

 Good find, thanks!

 Michael, can you try that patch [1] and see if it works for you?

 Peter, I think I'm just going to apply []] except that I'll make
BR2_PACKAGE_MESA3D_DRI3 a blind option (i.e. not user visible, only selected automatically by the drivers, much like BR2_PACKAGE_MESA3D_DRI).

 My other major comment about that patch was that I suspected that it
would need some 'select' statements, but I guess the autobuilders will inform us of that, so we can go ahead and merge it.

 Does that sound OK to you?

 Regards,
 Arnout

[1] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 8 lines

Regards, Bernd

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#11 lore raw

[Buildroot] [Bug 14451] nodejs won't build on Fedora 35

In reply to [email protected]

https://bugs.busybox.net/show_bug.cgi?id=14451

--- Comment #3 from Fabrice Fontaine <[email protected]> --- The following patch should fix this issue:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Moreover, python 3.10 support has been added to nodejs 14.18.2:
https://github.com/nodejs/node/releases/tag/v14.18.2

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#12 lore raw

[Buildroot] [Bug 14451] nodejs won't build on Fedora 35

In reply to [email protected]

https://bugs.busybox.net/show_bug.cgi?id=14451

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Peter Korsgaard <[email protected]> --- Fixed by
https://git.buildroot.org/buildroot/commit/?id=5ad7eb6c61d281912a8c692f0b69d46726394b10,
thanks

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot