New: EXT4 corruption
http://bugzilla.kernel.org/show_bug.cgi?id=14472
Summary: EXT4 corruption
Product: File System
Version: 2.5
Kernel Version: 2.6.32-rc4
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: ext4
AssignedTo: [email protected]
ReportedBy: [email protected]
Blocks: 14230
Regression: YesSubject : [2.6.32-rc4] + EXT4 corruption
Submitter : Shawn Starr <[email protected]>
Date : 2009-10-13 2:07
References : http://marc.info/?l=linux-kernel&m=125539997508256&w=4
Notify-Also : Andy Lutomirski <[email protected]>
This entry is being used for tracking a regression from 2.6.31. Please don't close it until the problem is fixed in the mainline.
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
[Bug 14472] EXT4 corruption
http://bugzilla.kernel.org/show_bug.cgi?id=14472
--- Comment #1 from Rafael J. Wysocki <[email protected]> 2009-10-29 21:31:10 ---
Quoted 26 lines · Andrew Lutomirski
Quoted 8 lines · Rafael J. Wysocki
This message has been generated automatically as a part of a report of recent regressions.
The following bug entry is on the current list of known regressions from 2.6.31. Please verify if it still should be listed and let me know (either way).
Quoted 7 lines
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14472
Subject : EXT4 corruption
Submitter : Shawn Starr <[email protected]>
Date : 2009-10-13 2:07 (14 days old)
References : http://marc.info/?l=linux-kernel&m=125539997508256&w=4Handled-By Theodore Tso <[email protected]>This but is *not* fixed. I just triggered it a few minutes ago by abusing i915 and drm, which caused a panic. This is slightly newer than 2.6.32-rc5, with a couple of i915 bugfixes thrown in.
Photos are here:
http://web.mit.edu/luto/www/ext4_crashphotos/This is a very nasty regression, for obvious reasons.
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
[Bug 14472] EXT4 corruption
In reply to [email protected]http://bugzilla.kernel.org/show_bug.cgi?id=14472
Parag Warudkar <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #2 from Parag Warudkar <[email protected]> 2009-10-29 21:38:47 --- I looked at the fsck pics - I have gone through this a few days ago.
Aneesh suggested to apply the below patch and after applying it and crashing the machine couple times I have not observed the corruption. So I have reason to hope this patch below on top of today's git should improve things. Please try.
commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65
Author: Aneesh Kumar K.V <[email protected]> Date: Tue Oct 27 15:36:38 2009 +0530
ext4: discard preallocation during truncate
We need to make sure when we drop and reacquire the inode's i_data_sem we discard the inode preallocation. Otherwise we could have blocks marked as free in bitmap but still belonging to prealloc space.
fs/ext4/inode.c +0 -0
@@ -209,6 +209,12 @@ static int try_to_extend_transaction(handle_t *handle,
struct inode *inode)
up_write(&EXT4_I(inode)->i_data_sem);
ret = ext4_journal_restart(handle, blocks_for_truncate(inode));
down_write(&EXT4_I(inode)->i_data_sem);
+ /*
+ * We have dropped i_data_sem. So somebody else could have done
+ * block allocation. So discard the prealloc space created as a
+ * part of block allocation
+ */+ ext4_discard_preallocations(inode);
return ret;
}
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
[Bug 14472] EXT4 corruption
In reply to [email protected]http://bugzilla.kernel.org/show_bug.cgi?id=14472
Eric Sandeen <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #3 from Eric Sandeen <[email protected]> 2009-10-29 21:44:45 --- Lest champagne break out too early, I have still seen corruption with this patch in place, while running my testcase (mentioned in bug #14354)
-Eric
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
[Bug 14472] EXT4 corruption
In reply to [email protected]http://bugzilla.kernel.org/show_bug.cgi?id=14472
--- Comment #4 from Rafael J. Wysocki <[email protected]> 2009-11-17 22:30:40 ---
Quoted 20 lines · Andy Lutomirski
I'm think this was the journal checksumming bug, which is fixed.
Quoted 15 lines · Rafael J. Wysocki
This message has been generated automatically as a part of a report of recent regressions.
The following bug entry is on the current list of known regressions from 2.6.31. Please verify if it still should be listed and let me know
(either way).Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14472
Subject : EXT4 corruption
Submitter : Shawn Starr <[email protected]>
Date : 2009-10-13 2:07 (35 days old)
References : http://marc.info/?l=linux-kernel&m=125539997508256&w=4Handled-By Theodore Tso <[email protected]>
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
[Bug 14472] EXT4 corruption
In reply to [email protected]http://bugzilla.kernel.org/show_bug.cgi?id=14472
Rafael J. Wysocki <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |CODE_FIXSignature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
[Bug 14472] EXT4 corruption
In reply to [email protected]http://bugzilla.kernel.org/show_bug.cgi?id=14472
Rafael J. Wysocki <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.