sky2 won't work after suspend/resume cycle
A message that is not in the archive (sent off-list or not yet received): [email protected]/
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 52 lines · On Monday 07 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #7 from Andrew Morton <[email protected]> 2009-12-07 19:51:32 --- (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 23 lines · On Fri, 4 Dec 2009 09:02:21 GMT [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
Summary: sky2 won't work after suspend/resume cycle
Product: Power Management
Version: 2.5
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: high
Priority: P1
Component: Hibernation/Suspend
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: YesI use sky2 network adapter in my Fujitsu Siemens Esprimo Mobile U9200. It worked fine up until 2.6.31-rc3 (or at least that's the last one I tried it works for me) and in all versions after that I tried it stops working after suspend/resume cycle (I use powersave daemon, but I also tried without it - effect is the same).
Quoted 7 lines
After resume what I see in dmesg is this:
sky2 driver version 1.23
sky2 0000:04:00.0: enabling device (0000 -> 0003) sky2 0000:04:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17 sky2 0000:04:00.0: setting latency timer to 64
sky2 0000:04:00.0: unsupported chip type0xffIt looks like reads from the device are returning all-ones.
Quoted 6 lines
sky2 0000:04:00.0: PCI INT A disabled
sky2: probe of 0000:04:00.0 failed with error -95So it looks like something is probably not restored correctly after resume or some initializations are not executed.
Quoted 6 lines
Quoted 3 lines
I use Gentoo sources, but I also tried it on vanilla kernels - 2.6.31 and 2.6.32-rc8 and it doesn't work in any version past 2.6.31-rc3.
Help. Do we think this regression is likely to be a sky2 thing, an ACPI thing, an x86 arch thing or...?
Quite frankly, I have no idea.
In principle that may be a result of a PCI PM core change, but nothing comes to mind immediately.
It may be worth trying to revert
commit 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff
Author: Rafael J. Wysocki <[email protected]> Date: Wed Sep 9 23:49:59 2009 +0200
PCI: Clear saved_state after the state has been restored
and retesting.
Quoted 52 lines · On Monday 07 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #7 from Andrew Morton <[email protected]> 2009-12-07 19:51:32 --- (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 23 lines · On Fri, 4 Dec 2009 09:02:21 GMT [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
Summary: sky2 won't work after suspend/resume cycle
Product: Power Management
Version: 2.5
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: high
Priority: P1
Component: Hibernation/Suspend
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: YesI use sky2 network adapter in my Fujitsu Siemens Esprimo Mobile U9200. It worked fine up until 2.6.31-rc3 (or at least that's the last one I tried it works for me) and in all versions after that I tried it stops working after suspend/resume cycle (I use powersave daemon, but I also tried without it - effect is the same).
Quoted 7 lines
After resume what I see in dmesg is this:
sky2 driver version 1.23
sky2 0000:04:00.0: enabling device (0000 -> 0003) sky2 0000:04:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17 sky2 0000:04:00.0: setting latency timer to 64
sky2 0000:04:00.0: unsupported chip type0xffIt looks like reads from the device are returning all-ones.
Quoted 6 lines
sky2 0000:04:00.0: PCI INT A disabled
sky2: probe of 0000:04:00.0 failed with error -95So it looks like something is probably not restored correctly after resume or some initializations are not executed.
Quoted 6 lines
Quoted 3 lines
I use Gentoo sources, but I also tried it on vanilla kernels - 2.6.31 and 2.6.32-rc8 and it doesn't work in any version past 2.6.31-rc3.
Help. Do we think this regression is likely to be a sky2 thing, an ACPI thing, an x86 arch thing or...?
Quite frankly, I have no idea.
In principle that may be a result of a PCI PM core change, but nothing comes to mind immediately.
It may be worth trying to revert
commit 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff
Author: Rafael J. Wysocki <[email protected]> Date: Wed Sep 9 23:49:59 2009 +0200
PCI: Clear saved_state after the state has been restored
and retesting.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · On Thursday 10 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #11 from Ilya Hegai <[email protected]> 2009-12-10 10:36:36 --- (In reply to comment #9)
Quoted 2 lines · On Monday 07 December 2009, [email protected] wrote:
Quoted 1 line
...
Quoted 8 lines
Quoted 8 lines
It may be worth trying to revert
commit
4b77b0a2ba27d64f58f16d8d4d48d8319dda36ffAuthor: Rafael J. Wysocki <[email protected]> Date: Wed Sep 9 23:49:59 2009 +0200PCI: Clear
saved_stateafter the state has been restored
Quoted 8 lines
Quoted 1 line
and retesting.
I'm not familiar with git, but I haven't found traces of that commit in 2.6.31.7 that I'm using (gentoo-sources) (and the problem exists there) but after I applied it (got it from git) - sky2 errors after hibernation/resume dissapeared
And as I can see this patch has applied against 2.6.32, so I guess TS person is considered to upgrade to the latest kernel
Hmm. The original report is against 2.6.32-rc8.
So you're saying that the commit above, when applied against 2.6.31.7, actually fixes a sky2 resume problem for you?
Maciej, can you please check if 2.6.31.7 with the above commit applied works for you?
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 28 lines · Rafael J. Wysocki
Quoted 7 lines · On Thursday 10 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #11 from Ilya Hegai <[email protected]> 2009-12-10 10:36:36 --- (In reply to comment #9)
Quoted 2 lines · On Monday 07 December 2009, [email protected] wrote:
Quoted 1 line
...
Quoted 8 lines
Quoted 8 lines
It may be worth trying to revert
commit
4b77b0a2ba27d64f58f16d8d4d48d8319dda36ffAuthor: Rafael J. Wysocki <[email protected]> Date: Wed Sep 9 23:49:59 2009 +0200PCI: Clear
saved_stateafter the state has been restoredQuoted 8 lines
Quoted 1 line
and retesting.
I'm not familiar with git, but I haven't found traces of that commit in 2.6.31.7 that I'm using (gentoo-sources) (and the problem exists there) but after I applied it (got it from git) - sky2 errors after hibernation/resume dissapeared
And as I can see this patch has applied against 2.6.32, so I guess TS person is considered to upgrade to the latest kernel
Quoted 8 lines
Hmm. The original report is against 2.6.32-rc8.
So you're saying that the commit above, when applied against 2.6.31.7, actually fixes a sky2 resume problem for you?
Maciej, can you please check if 2.6.31.7 with the above commit applied
works for you?
Well... I've downloaded the patch from git. The working kernel - 2.6.31-rc3 does not have it aplied, but later versions do, so I tried to revert it on the latest gentoo sources (2.6.32) - it reverted fine, but it didn't really helped
- after suspend/resume sky2 does not work. I'll try gentoo-sources-2.6.31-r7 right now and I'll let you know of the results.
m.
Signature · 7 lines
Maciej J. Woloszyk, <[email protected]> "Rejoice. For Very Bad tel. +48 501 033 410 Things are about to happen." JID:[email protected] Richard/Looking For Group _______________________________________________ linux-pm mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/linux-pm
Quoted 28 lines · Rafael J. Wysocki
Quoted 7 lines · On Thursday 10 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #11 from Ilya Hegai <[email protected]> 2009-12-10 10:36:36 --- (In reply to comment #9)
Quoted 2 lines · On Monday 07 December 2009, [email protected] wrote:
Quoted 1 line
...
Quoted 8 lines
Quoted 8 lines
It may be worth trying to revert
commit
4b77b0a2ba27d64f58f16d8d4d48d8319dda36ffAuthor: Rafael J. Wysocki <[email protected]> Date: Wed Sep 9 23:49:59 2009 +0200PCI: Clear
saved_stateafter the state has been restoredQuoted 8 lines
Quoted 1 line
and retesting.
I'm not familiar with git, but I haven't found traces of that commit in 2.6.31.7 that I'm using (gentoo-sources) (and the problem exists there) but after I applied it (got it from git) - sky2 errors after hibernation/resume dissapeared
And as I can see this patch has applied against 2.6.32, so I guess TS person is considered to upgrade to the latest kernel
Quoted 8 lines
Hmm. The original report is against 2.6.32-rc8.
So you're saying that the commit above, when applied against 2.6.31.7, actually fixes a sky2 resume problem for you?
Maciej, can you please check if 2.6.31.7 with the above commit applied
works for you?
Ok. I've just tried 2.6.31.7 with the patch applied - it didn't worked. sky2 still does'nt work after resume.
m.
Signature · 7 lines
Maciej J. Woloszyk, <[email protected]> "Rejoice. For Very Bad tel. +48 501 033 410 Things are about to happen." JID:[email protected] Richard/Looking For Group _______________________________________________ linux-pm mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/linux-pm
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 34 lines · Maciej J. Woloszyk
Quoted 33 lines · Rafael J. Wysocki
Quoted 7 lines · On Thursday 10 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #11 from Ilya Hegai <[email protected]> 2009-12-10 10:36:36 --- (In reply to comment #9)
Quoted 2 lines · On Monday 07 December 2009, [email protected] wrote:
Quoted 1 line
...
Quoted 8 lines
Quoted 8 lines
It may be worth trying to revert
commit
4b77b0a2ba27d64f58f16d8d4d48d8319dda36ffAuthor: Rafael J. Wysocki <[email protected]> Date: Wed Sep 9 23:49:59 2009 +0200PCI: Clear
saved_stateafter the state has been restoredQuoted 8 lines
Quoted 1 line
and retesting.
I'm not familiar with git, but I haven't found traces of that commit in 2.6.31.7 that I'm using (gentoo-sources) (and the problem exists there) but after I applied it (got it from git) - sky2 errors after hibernation/resume dissapeared
And as I can see this patch has applied against 2.6.32, so I guess TS person is considered to upgrade to the latest kernelHmm. The original report is against 2.6.32-rc8.
So you're saying that the commit above, when applied against 2.6.31.7, actually fixes a sky2 resume problem for you?
Quoted 6 lines
Quoted 3 lines
Maciej, can you please check if 2.6.31.7 with the above commit applied
works for you?Ok. I've just tried 2.6.31.7 with the patch applied - it didn't worked. sky2 still does'nt work after resume.
So the problem is clearly different for you. It also means it's not universal for all sky2s, so it may depend on whether the adapter is PCIe or something.
Can you please use 2.6.32 for further testing and do the following:
# echo code > /sys/power/pm_test # echo mem > /sys/power/state
wait until it gets back to the command prompt and see if your sky2 works after that?
_______________________________________________
linux-pm mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 9 lines · Rafael J. Wysocki
Quoted 8 lines · Maciej J. Woloszyk
Quoted 7 lines · Rafael J. Wysocki
Quoted 6 lines · On Thursday 10 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #11 from Ilya Hegai <[email protected]>
2009-12-10 10:36:36 --- (In reply to comment #9)Quoted 1 line
On Monday 07 December 2009, [email protected]
Quoted 29 lines · wrote:
Quoted 29 lines
Quoted 28 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
...
Quoted 8 lines
Quoted 8 lines
It may be worth trying to revert
commit
4b77b0a2ba27d64f58f16d8d4d48d8319dda36ffAuthor: Rafael J. Wysocki <[email protected]> Date: Wed Sep 9 23:49:59 2009 +0200PCI: Clear
saved_stateafter the state has been restoredQuoted 8 lines
Quoted 1 line
and retesting.
I'm not familiar with git, but I haven't found traces of that commit in 2.6.31.7 that I'm using (gentoo-sources) (and the problem exists there) but after I applied it (got it from git) - sky2 errors after hibernation/resume dissapeared
And as I can see this patch has applied against 2.6.32, so I guess TS person is considered to upgrade to the latest kernelHmm. The original report is against 2.6.32-rc8.
So you're saying that the commit above, when applied against 2.6.31.7, actually fixes a sky2 resume problem for you?
Maciej, can you please check if 2.6.31.7 with the above commit applied
works for you?
Quoted 9 lines
Quoted 2 lines
Ok. I've just tried 2.6.31.7 with the patch applied - it didn't worked. sky2 still does'nt work after resume.
So the problem is clearly different for you. It also means it's not
universal for all sky2s, so it may depend on whether the adapter is PCIe or something.Can you please use 2.6.32 for further testing and do the following:
Ok.
Quoted 1 line
# echo code > /sys/power/pm_test
I hope you ment it to be "echo core" because if it actualy supposed to be "code" - it didn't worked ;)
Quoted 5 lines
# echo mem > /sys/power/statewait until it gets back to the command prompt and see if your sky2 works after that?
Yes - after the second echo it did kind of suspend/resume cycle and after that sky2 still worked.
_______________________________________________
linux-pm mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
A message that is not in the archive (sent off-list or not yet received): [email protected]
On Thursday 10 December 2009, Maciej J. Woloszyk wrote:
...
Quoted 9 lines
Quoted 2 lines
Can you please use 2.6.32 for further testing and do the following:
Ok.
Quoted 1 line
# echo code > /sys/power/pm_testI hope you ment it to be "echo core" because if it actualy supposed to be "code" - it didn't worked ;)
Yes, that should have been 'core', sorry for the mistake.
Quoted 8 lines
Quoted 5 lines
# echo mem > /sys/power/statewait until it gets back to the command prompt and see if your sky2 works after that?
Yes - after the second echo it did kind of suspend/resume cycle and after that sky2 still worked.
OK, thanks.
Please attach the full output of 'lspci -vv' (including all devices) before and after a suspend-resume cycle failing to restore the sky2 functionality.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · On Friday 11 December 2009, [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14730
--- Comment #23 from Ilya Hegai <[email protected]> 2009-12-11 08:34:41 --- Me too) because I'm still experiencing that problem, yesterday several hibernate/resume cycles went smoothly, but today I've got that error again, so it's not reproducible always which makes "patch hunting" work harder
So the commit we have discussed doesn't help to fix resume on your box after all?
Quoted 2 lines
And unfortunately I can play with 2.6.31.X only, because resume in 2.6.32 is completely broken for my laptop
I think you should file a separate bug report about that.
Is there any kernel where suspend/resume works reliably on your box?