MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
Subsystems (2)
http://bugzilla.kernel.org/show_bug.cgi?id=14877
Andrew Morton <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected], | |[email protected] Component|PCI |Other AssignedTo|[email protected] |scsi_drivers-other@kernel-b |l.org |ugs.osdl.org Product|Drivers |SCSI Drivers Regression|No |Yes
--- Comment #2 from Andrew Morton <[email protected]> 2010-01-14 22:27:15 --- Thanks. I'll mark this as a regression, shall reassign to scsi and shall ask you to email a signed-off version of that patch.
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #3 from Andrew Morton <[email protected]> 2010-01-14 23:02:19 --- (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 18 lines · On Thu, 14 Jan 2010 22:27:18 GMT [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14877
Andrew Morton <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------CC| |[email protected], | |[email protected] Component|PCI |Other AssignedTo|[email protected] |scsi_drivers-other@kernel-b |l.org |ugs.osdl.org Product|Drivers |SCSI Drivers Regression|No |Yes
Quoted 4 lines
--- Comment #2 from Andrew Morton <[email protected]> 2010-01-14 22:27:15 --- Thanks. I'll mark this as a regression, shall reassign to scsi and shall ask you to email a signed-off version of that patch.
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per Documentation/SubmittingPatches, thanks.
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 18 lines · On Thu, 14 Jan 2010 22:27:18 GMT [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=14877
Andrew Morton <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------CC| |[email protected], | |[email protected] Component|PCI |Other AssignedTo|[email protected] |scsi_drivers-other@kernel-b |l.org |ugs.osdl.org Product|Drivers |SCSI Drivers Regression|No |Yes
Quoted 4 lines
--- Comment #2 from Andrew Morton <[email protected]> 2010-01-14 22:27:15 --- Thanks. I'll mark this as a regression, shall reassign to scsi and shall ask you to email a signed-off version of that patch.
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per Documentation/SubmittingPatches, thanks.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #4 from Oleg Gawriloff <[email protected]> 2010-01-15 07:22:42 --- Sorry, I'm not kernel developer. Signed-off-by version is available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #5 from Oleg Gawriloff <[email protected]> 2010-01-15 07:24:05 --- 15.01.2010 1:01, Andrew Morton пишет:
Quoted 3 lines
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per
Documentation/SubmittingPatches, thanks.
Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2
From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts.
This patch restores lpfc's ability to support MSI-X/MSI interrupts that the "Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X is not
supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
--- drivers/scsi/lpfc/lpfc_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/lpfc/lpfc_attr.c +3 -3
@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,/* # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that # support this feature -# 0 = MSI disabled (default) +# 0 = MSI disabled # 1 = MSI enabled -# 2 = MSI-X enabled +# 2 = MSI-X enabled (default) # Value range is [0,2]. Default value is 0. */ -LPFC_ATTR_R (use_msi,0 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " +LPFC_ATTR_R (use_msi,2 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " "MSI-X (2), if possible" );/*
Signature · 9 lines
Signed, Oleg Gawriloff. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.-- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
15.01.2010 1:01, Andrew Morton пишет:
Quoted 3 lines
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per
Documentation/SubmittingPatches, thanks.
Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2
From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts. This patch restores lpfc's ability to support MSI-X/MSI interrupts that the "Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X is not supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
--- drivers/scsi/lpfc/lpfc_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/lpfc/lpfc_attr.c +3 -3
@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,/* # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that # support this feature -# 0 = MSI disabled (default) +# 0 = MSI disabled # 1 = MSI enabled -# 2 = MSI-X enabled +# 2 = MSI-X enabled (default) # Value range is [0,2]. Default value is 0. */ -LPFC_ATTR_R (use_msi,0 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " +LPFC_ATTR_R (use_msi,2 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " "MSI-X (2), if possible" );/*
Signature · 1 line
Signed, Oleg Gawriloff.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #6 from Andrew Morton <[email protected]> 2010-01-22 23:18:19 ---
Quoted 36 lines · On Fri, 15 Jan 2010 09:23:50 +0200 Oleg Gawriloff <[email protected]> wrote:
15.01.2010 1:01, Andrew Morton __________:
Quoted 3 lines
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per
Documentation/SubmittingPatches, thanks.Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts.
This patch restores lpfc's ability to support MSI-X/MSI interrupts that the "Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X is not
supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commitda0436e915a5c17ee79e72c1bf978a4ebb1cbf4dSigned-off-by George Kadianakis <desnacked {cat} gmail {dog} com>--- drivers/scsi/lpfc/lpfc_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/scsi/lpfc/lpfc_attr.c +0
-1@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,/* # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that # support this feature -# 0 = MSI disabled (default)
drivers/scsi/lpfc/lpfc_attr.c LPFC_ATTR_RW(poll_tmo, 10, 1, 255, · line 2900
Quoted 10 lines
drivers/scsi/lpfc/lpfc_attr.c +3
-2+# 0 = MSI disabled # 1 = MSI enabled -# 2 = MSI-X enabled +# 2 = MSI-X enabled (default) # Value range is [0,2]. Default value is 0. */ -LPFC_ATTR_R (use_msi,0 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " +LPFC_ATTR_R (use_msi,2 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " "MSI-X (2), if possible" );
This is committed to the scsi tree without a cc:stable, so it won't get backported into 2.6.32.x and might not make it into 2.6.33 either.
Was that all intentional?
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
Quoted 36 lines · On Fri, 15 Jan 2010 09:23:50 +0200 Oleg Gawriloff <[email protected]> wrote:
15.01.2010 1:01, Andrew Morton __________:
Quoted 3 lines
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per
Documentation/SubmittingPatches, thanks.Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts.
This patch restores lpfc's ability to support MSI-X/MSI interrupts that the "Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X is not
supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commitda0436e915a5c17ee79e72c1bf978a4ebb1cbf4dSigned-off-by George Kadianakis <desnacked {cat} gmail {dog} com>--- drivers/scsi/lpfc/lpfc_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/scsi/lpfc/lpfc_attr.c +0
-1@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,/* # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that # support this feature -# 0 = MSI disabled (default)
drivers/scsi/lpfc/lpfc_attr.c LPFC_ATTR_RW(poll_tmo, 10, 1, 255, · line 2900
Quoted 10 lines
drivers/scsi/lpfc/lpfc_attr.c +3
-2+# 0 = MSI disabled # 1 = MSI enabled -# 2 = MSI-X enabled +# 2 = MSI-X enabled (default) # Value range is [0,2]. Default value is 0. */ -LPFC_ATTR_R (use_msi,0 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " +LPFC_ATTR_R (use_msi,2 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " "MSI-X (2), if possible" );
This is committed to the scsi tree without a cc:stable, so it won't get backported into 2.6.32.x and might not make it into 2.6.33 either.
Was that all intentional?
Quoted 53 lines · Andrew Morton
Quoted 36 lines · On Fri, 15 Jan 2010 09:23:50 +0200 Oleg Gawriloff <[email protected]> wrote:
15.01.2010 1:01, Andrew Morton __________:
Quoted 3 lines
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per
Documentation/SubmittingPatches, thanks.Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts.
This patch restores lpfc's ability to support MSI-X/MSI interrupts that the "Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X is not
supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commitda0436e915a5c17ee79e72c1bf978a4ebb1cbf4dSigned-off-by George Kadianakis <desnacked {cat} gmail {dog} com>--- drivers/scsi/lpfc/lpfc_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/scsi/lpfc/lpfc_attr.c +0
-1@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,/* # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that # support this feature -# 0 = MSI disabled (default) drivers/scsi/lpfc/lpfc_attr.c LPFC_ATTR_RW(poll_tmo, 10, 1, 255, · line 2900
Quoted 10 lines
drivers/scsi/lpfc/lpfc_attr.c +3
-2+# 0 = MSI disabled # 1 = MSI enabled -# 2 = MSI-X enabled +# 2 = MSI-X enabled (default) # Value range is [0,2]. Default value is 0. */ -LPFC_ATTR_R (use_msi,0 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " +LPFC_ATTR_R (use_msi,2 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " "MSI-X (2), if possible" );This is committed to the scsi tree without a cc:stable, so it won't get backported into 2.6.32.x and might not make it into 2.6.33 either.
Quoted 1 line
Was that all intentional?
Yes.
The commit contains an essay from James Smart as a sidebar explaining the logic, but the gist is that there were instabilities in the previous kernel that caused MSI failures with the lpfc cards so disabling MSI was deliberate.
James
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #7 from Anonymous Emailer <[email protected]> 2010-01-23 14:25:26 ---
Reply-To: [email protected]
Quoted 53 lines · Andrew Morton
Quoted 36 lines · On Fri, 15 Jan 2010 09:23:50 +0200 Oleg Gawriloff <[email protected]> wrote:
15.01.2010 1:01, Andrew Morton __________:
Quoted 3 lines
Oleg, please send that lpfc patch via emailed reply-to-all to this email. Include a brief description for the changelog and a Signed-off-by: as per
Documentation/SubmittingPatches, thanks.Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts.
This patch restores lpfc's ability to support MSI-X/MSI interrupts that the "Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X is not
supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commitda0436e915a5c17ee79e72c1bf978a4ebb1cbf4dSigned-off-by George Kadianakis <desnacked {cat} gmail {dog} com>--- drivers/scsi/lpfc/lpfc_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/scsi/lpfc/lpfc_attr.c +0
-1@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,/* # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that # support this feature -# 0 = MSI disabled (default) drivers/scsi/lpfc/lpfc_attr.c LPFC_ATTR_RW(poll_tmo, 10, 1, 255, · line 2900
Quoted 10 lines
drivers/scsi/lpfc/lpfc_attr.c +3
-2+# 0 = MSI disabled # 1 = MSI enabled -# 2 = MSI-X enabled +# 2 = MSI-X enabled (default) # Value range is [0,2]. Default value is 0. */ -LPFC_ATTR_R (use_msi,0 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " +LPFC_ATTR_R (use_msi,2 ,0 ,2 ,"Use Message Signaled Interrupts (1) or " "MSI-X (2), if possible" );This is committed to the scsi tree without a cc:stable, so it won't get backported into 2.6.32.x and might not make it into 2.6.33 either.
Quoted 1 line
Was that all intentional?
Yes.
The commit contains an essay from James Smart as a sidebar explaining the logic, but the gist is that there were instabilities in the previous kernel that caused MSI failures with the lpfc cards so disabling MSI was deliberate.
James
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #8 from Oleg Gawriloff <[email protected]> 2010-01-23 14:29:11 --- Hmm, I've running my system without any problems more then year. I've understand the point that if someone see MSI instability on lpfc it should be turned off by default, but is there any way to activate MSI by hand?
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
Quoted 4 lines · On Sat, 2010-01-23 at 14:29 +0000, [email protected] wrote:
--- Comment #8 from Oleg Gawriloff <[email protected]> 2010-01-23 14:29:11 --- Hmm, I've running my system without any problems more then year. I've understand the point that if someone see MSI instability on lpfc it should be turned off by default, but is there any way to activate MSI by hand?
Yes, with the module parameter. Just set it to 2 again and it will do MSI.
James
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #9 from Anonymous Emailer <[email protected]> 2010-01-23 14:57:20 ---
Reply-To: [email protected]
Quoted 4 lines · On Sat, 2010-01-23 at 14:29 +0000, [email protected] wrote:
--- Comment #8 from Oleg Gawriloff <[email protected]> 2010-01-23 14:29:11 --- Hmm, I've running my system without any problems more then year. I've understand the point that if someone see MSI instability on lpfc it should be turned off by default, but is there any way to activate MSI by hand?
Yes, with the module parameter. Just set it to 2 again and it will do MSI.
James
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #10 from Oleg Gawriloff <[email protected]> 2010-01-23 15:36:40 --- Tried (I'm on Gentoo) on 2.6.32.4 kernel:/etc/modules.autoload.d/kernel-2.6:
lpfc lpfc_use_msi=2
nothing changes (still on IO-APIC-fasteoi).
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #11 from James Smart <[email protected]> 2010-01-23 22:34:26 ---
Note: this isn't a problem with lpfc - it was a problem with a couple of specific hardware platforms that didn't properly support MSI.
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #12 from James Smart <[email protected]> 2010-01-24 01:22:30 ---
BTW: for your test - it depends on what adapter you have as to whether it supports MSI-X, MSI, or only INTx.
Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.