Skip to contentSkip to conversation

New: Fail to get ethernet IP-adress

Bugme-new Andrew Morton 3 participants 3 messages Jan 26, 2010 1 message not in the archive Networking drivers (wireless)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

#1 lore raw

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 1 line · On Tue, 19 Jan 2010 14:35:03 GMT [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=15089

2.6.32.2 -> 2.6.32.3 regression. Hence the regression is probably in 2.6.33-rc.

Looking through the changelog I'd be suspecting

: commit 3815270b3107d31c8b7bd69461f0bb3c350ee25c : Author: Gertjan van Wingerde <[email protected]>
: Date: Mon Dec 14 20:33:55 2009 +0100
:
: rt2x00: Disable powersaving for rt61pci and rt2800pci.
:
: commit 93b6bd26b74efe46b4579592560f9f1cb7b61994 upstream.

Mainly because I didn't spot any other change to that driver.

Krister, are you able to apply this reversion patch to 2.6.32.3 and see if it helps?

Thanks.

 drivers/net/wireless/rt2x00/rt2800lib.c |    6 ------
 drivers/net/wireless/rt2x00/rt61pci.c   |    5 -----
 2 files changed, 11 deletions(-)
drivers/net/wireless/rt2x00/rt2800lib.c renamed from drivers/net/wireless/rt2x00/rt2800lib.c~revert-1 +0 -6
diff -puN drivers/net/wireless/rt2x00/rt2800lib.c~revert-1 drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2037,12 +2037,6 @@ int rt2800_probe_hw_mode(struct rt2x00_d
 	u16 eeprom;
 
 	/*
-	 * Disable powersaving as default on PCI devices.
-	 */
-	if (rt2x00_intf_is_pci(rt2x00dev))
-		rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
-	/*
 	 * Initialize all hw fields.
 	 */
 	rt2x00dev->hw->flags =
drivers/net/wireless/rt2x00/rt61pci.c renamed from drivers/net/wireless/rt2x00/rt61pci.c~revert-1 +0 -5
diff -puN drivers/net/wireless/rt2x00/rt61pci.c~revert-1 drivers/net/wireless/rt2x00/rt61pci.c
@@ -2535,11 +2535,6 @@ static int rt61pci_probe_hw_mode(struct 
 	unsigned int i;
 
 	/*
-	 * Disable powersaving as default.
-	 */
-	rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
-	/*
 	 * Initialize all hw fields.
 	 */
 	rt2x00dev->hw->flags =

_

#2 lore raw

No sorry, I'm currently not capable to recompile my kernel. I hope someone else with a similar problem comes along.

Quoted 74 lines · Andrew Morton

(switched to email.  Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 1 line · On Tue, 19 Jan 2010 14:35:03 GMT [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=15089

2.6.32.2 -> 2.6.32.3 regression.  Hence the regression is probably in 2.6.33-rc.

Looking through the changelog I'd be suspecting

: commit 3815270b3107d31c8b7bd69461f0bb3c350ee25c
: Author: Gertjan van Wingerde <[email protected]> : Date:   Mon Dec 14 20:33:55 2009 +0100
:
:     rt2x00: Disable powersaving for rt61pci and rt2800pci. :
:     commit 93b6bd26b74efe46b4579592560f9f1cb7b61994 upstream.

Mainly because I didn't spot any other change to that driver.

Krister, are you able to apply this reversion patch to 2.6.32.3 and see if it helps?

Thanks.

 drivers/net/wireless/rt2x00/rt2800lib.c |    6 ------ drivers/net/wireless/rt2x00/rt61pci.c   |    5 -----

 2 files changed, 11 deletions(-)

diff -puN drivers/net/wireless/rt2x00/rt2800lib.c~revert-1 drivers/net/wireless/rt2x00/rt2800lib.c

drivers/net/wireless/rt2x00/rt2800lib.c renamed from drivers/net/wireless/rt2x00/rt2800lib.c~revert-1 +0 -6
@@ -2037,12 +2037,6 @@ int rt2800_probe_hw_mode(struct rt2x00_d
        u16 eeprom;
 
        /*
-        * Disable powersaving as default on PCI devices.
-        */
-       if (rt2x00_intf_is_pci(rt2x00dev))
-               rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
-       /*
         * Initialize all hw fields.
         */

       rt2x00dev->hw->flags =
diff -puN drivers/net/wireless/rt2x00/rt61pci.c~revert-1 drivers/net/wireless/rt2x00/rt61pci.c

drivers/net/wireless/rt2x00/rt61pci.c renamed from drivers/net/wireless/rt2x00/rt61pci.c~revert-1 +0 -5
@@ -2535,11 +2535,6 @@ static int rt61pci_probe_hw_mode(struct
        unsigned int i;
 
        /*
-        * Disable powersaving as default.
-        */
-       rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
-       /*
         * Initialize all hw fields.
         */

       rt2x00dev->hw->flags =
_

#3 lore raw
Quoted 2 lines · Krister Svanlund

No sorry, I'm currently not capable to recompile my kernel. I hope someone else with a similar problem comes along.

Then how do you know the regression happened between 2.6.32.2 and 2.6.32.3?

confused,

greg k-h