New: Netlink is notifying RTNLGRP_IPV6_IFADDR instead of RTNLGRP_IPV6_IFINFO

Bugme-new Andrew Morton 1 participant 1 message Apr 5, 2010 1 message not in the archive

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Andrew Morton

author

2010-04-05 19:56 UTC #1 lore raw

In reply to a message not in the archive

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 38 lines · On Fri, 2 Apr 2010 18:35:14 GMT [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=15684
           Summary: Netlink is notifying RTNLGRP_IPV6_IFADDR instead of
                    RTNLGRP_IPV6_IFINFO
           Product: Networking
           Version: 2.5
    Kernel Version: 2.6.28-2
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: IPV6
        AssignedTo: [email protected]
        ReportedBy: [email protected]
        Regression: No
It seems the inet6_ifinfo_notify function placed in "net/ipv6/addrconf.c" is notifying the wrong netlink group (RTNLGRP_IPV6_IFADDR) with ifinfo structure.
So I suggest the correction below (RTNLGRP_IPV6_IFINFO takes the place of RTNLGRP_IPV6_IFADDR):
void inet6_ifinfo_notify(int event, struct inet6_dev *idev) {
...
   err = rtnl_notify(skb, net, 0, RTNLGRP_IPV6_IFINFO, NUL, GFP_ATOMIC);
...
errout:
   if (err < 0)
      rtnl_set_sk_err(net, RTNLGRP_IPV6_IFINFO, err);
}