Skip to contentSkip to conversation

New: drivers/scsi/mpt3sas/mpt3sas_scsih.c _scsih_ir_fastpath ambiguous path structures

Bug 194341 [email protected] 1 participant 1 message Feb 7, 2017 SCSI

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=194341

Bug ID: 194341
Summary: drivers/scsi/mpt3sas/mpt3sas_scsih.c
_scsih_ir_fastpath ambiguous path structures
Product: SCSI Drivers
Version: 2.5
Kernel Version: 4.10
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: enhancement
Priority: P1
Component: Other
Assignee: [email protected]
Reporter: [email protected]
Regression: No

Given the number of error checks and intermittent conditional branches all ending with the same error code, it may be worth restructuring this path to optimistically execute the fast path and then have a single set of error checks at the end, since all of the errors immediately exit the function with a error code anyways.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.