New: sky2 wake on line stopped working in 2.6.34/2.6.35
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]/
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 17 lines · On Sat, 2 Oct 2010 08:30:14 GMT [email protected] wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=19492
Summary: sky2 wake on line stopped working in 2.6.34/2.6.35 Product: Drivers Version: 2.5 Kernel Version: 2.6.34, 2.6.35 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Network AssignedTo: [email protected] ReportedBy: [email protected] Regression: Yes
A regression.
Quoted 14 lines
sky2 WOL feature stopped working in 2.6.34 kernel. It was working fine in 2.6.33. ethtool 2.6.35 (and some earlier version before).
# ethtool -s eth0 wol g # ethtool eth0|grep Wake Supports Wake-on: pg Wake-on: g # ethtool -i eth0 driver: sky2 version: 1.28 firmware-version: N/A bus-info: 0000:05:00.0 # poweroff
Quoted 6 lines
When googling for solution I found
/sys/class/net/eth0/device/power/wakeupwhich contains "disabled" before AND after I run ethtool. So I echoed "enabled" there, too but it didn't help. The machine doesn't wake up on magick packet....
I can't immediately see any recent changes to the driver in that area apart from "ethtool: Change ethtool_op_set_flags to validate flags". Perhaps you could run
strace -f ethtool -s eth0 wol g
and see if it's getting an error when setting WOL mode. If so, ethtool is broken ;)
Quoted 48 lines · On Mon, 4 Oct 2010 15:14:04 -0700 Andrew Morton <[email protected]>…
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 17 lines · On Sat, 2 Oct 2010 08:30:14 GMT [email protected] wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=19492
Summary: sky2 wake on line stopped working in 2.6.34/2.6.35 Product: Drivers Version: 2.5 Kernel Version: 2.6.34, 2.6.35 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Network AssignedTo: [email protected] ReportedBy: [email protected] Regression: YesA regression.
Quoted 14 lines
sky2 WOL feature stopped working in 2.6.34 kernel. It was working fine in 2.6.33. ethtool 2.6.35 (and some earlier version before).
# ethtool -s eth0 wol g # ethtool eth0|grep Wake Supports Wake-on: pg Wake-on: g # ethtool -i eth0 driver: sky2 version: 1.28 firmware-version: N/A bus-info: 0000:05:00.0 # poweroffQuoted 6 lines
When googling for solution I found
/sys/class/net/eth0/device/power/wakeupwhich contains "disabled" before AND after I run ethtool. So I echoed "enabled" there, too but it didn't help. The machine doesn't wake up on magick packet....
Quoted 9 lines
I can't immediately see any recent changes to the driver in that area apart from "ethtool: Change
ethtool_op_set_flagsto validate flags". Perhaps you could runstrace -f ethtool -s eth0 wol g
and see if it's getting an error when setting WOL mode. If so, ethtool is broken ;)
There have been changes in the core power management layer, that is where I would look. Usually the problem is the incorrectly BIOS marks the device as unable to do PM. Probably the old kernel ignored the BIOS, and newer kernels look at it more closely?
Last WoL changes were to make driver follow vendor driver which happened between 2.6.33 and 2.6.34
commit 5f8ae5c537d937bab9cfeb83a30a9b670c3cfb35
Author: stephen hemminger <[email protected]> Date: Fri Feb 12 06:57:59 2010 +0000
sky2: WoL changes
Change Wake On Lan code to be similar to vendor driver. The definition of Y2_HW_WOL_ON is confusing; what it means is transition to firmware SPI setting when doing power change.
Since same code is done for both shutdown and suspend, use common code path.
commit 87b09f1f25cd1e01d7c50bf423c7fe33027d7511
Author: stephen hemminger <[email protected]> Date: Fri Feb 12 06:58:00 2010 +0000
sky2: dont enable PME legacy mode
This bit is not changed by vendor driver, and should be left alone. The documentation implies this a debug bit.
0 = WAKE# only asserted when VMAIN not available
1 = WAKE# is depend on wake events and independent of VMAIN.