Skip to contentSkip to conversation

sysfs duplicate filename on driver loading Adaptec AIC-9410W

Bug 201609 James Bottomley 1 participant 1 message Jan 26, 2019 2 messages not in the archive PCI

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive
Quoted 17 lines · On Sat, 2019-01-26 at 03:13 +0000, [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=201609

Pablo Ruiz García ([email protected]) changed:

What |Removed |Added
-------------------------------------------------------------------
---------
CC| |[email protected]

--- Comment #2 from Pablo Ruiz García ([email protected]) --- Hi,

I've stumbled upon this very same issue, and have created a github repo with a
fix for the actual issue (see git commit's description for bug details).

Quoted 5 lines

https://github.com/pruiz/aic94xx-hotfix
https://github.com/pruiz/aic94xx-hotfix/commit/01898ea7dff8eb52f43773
ea3b59ab41ef2482c8

Hope it helps someone.

I think the correct fix is to rename the ai94xx revision file (say to aic94x_revision). However I've got to say that commit

commit 702ed3be1b1bf4dea05954168321741c0910c645

Author: Emil Velikov <[email protected]>
Date:   Mon Nov 21 16:24:49 2016 -0600

PCI: Create revision file in sysfs

Was a blatently silly thing to do without trying to namespace the added file (say calling it something less generic like pci_revision). I assume we're lucky and nothing in userspace depends on the 'revision' sysfs file of the aic driver, but technically I should request reversion of this patch on the grounds that it's broken our ABI (since that's what exported sysfs files are).

James