Skip to contentSkip to conversation

New: Wrong outbound region start address calculation in Keystone II PCIe driver

Bug 202319 Bjorn Helgaas 1 participant 1 message Jan 17, 2019 1 message not in the archive PCI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

#1 lore raw

Hi Yurii, Murali,

The patch attached to the bugzilla would need to be updated to apply to the current tree (looks like it was generated in a tree before we moved things to drivers/pci/controller/dwc/). It would also need to be posted to [email protected] with a changelog and signed-off-by (see
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst)

---------- Forwarded message ---------
From: <[email protected]>
Date: Thu, Jan 17, 2019 at 6:14 AM
Subject: [Bug 202319] New: Wrong outbound region start address calculation in Keystone II PCIe driver
To: <[email protected]>

https://bugzilla.kernel.org/show_bug.cgi?id=202319

Bug ID: 202319
Summary: Wrong outbound region start address calculation in
Keystone II PCIe driver
Product: Drivers
Version: 2.5
Kernel Version: 4.14
Hardware: ARM
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: PCI
Assignee: [email protected]
Reporter: [email protected]
Regression: No

Created attachment 280553
--> https://bugzilla.kernel.org/attachment.cgi?id=280553&action=edit
Fixes wrong OB_OFFSET_INDEX calculation in Keystone II PCIe driver

In function ks_pcie_setup_rc_app_regs (drivers/pci/dwc/pci-keystone.c:602):

---

/* Using Direct 1:1 mapping of RC <-> PCI memory space */

for (i = 0; i < num_viewport && (start < end); i++) {
        ks_pcie_app_writel(ks_pcie, OB_OFFSET_INDEX(i),
                           lower_32_bits(start) | OB_ENABLEN);
        ks_pcie_app_writel(ks_pcie, OB_OFFSET_HI(i),
                           upper_32_bits(start));
        start += OB_WIN_SIZE;
}

---

Here OB_WIN_SIZE is declared as 8, so region start address is incremented by 8 instead of 8M.

--
You are receiving this mail because:
You are watching the assignee of the bug.