Skip to contentSkip to conversation

New: Compilation for PPC64 fails on warning in watchdog.o

Bug 205303 [email protected] 1 participant 4 messages Oct 24, 2019 – Jul 23, 2021

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=205303

            Bug ID: 205303
           Summary: Compilation for PPC64 fails on warning in watchdog.o
           Product: Platform Specific/Hardware
           Version: 2.5
    Kernel Version: 5.3.7
          Hardware: PPC-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: blocking
          Priority: P1
         Component: PPC-64
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

Kernel compilation of 5.3.7 on PowerPC 64bit fails with a compiler warning treated as an error.

arch/powerpc/kernel/watchdog.c: In function *watchdog_smp_panic*:
arch/powerpc/kernel/watchdog.c:175:4: error: implicit declaration of function *smp_send_nmi_ipi*: did you mean *smp_send_stop*? [-Werror=implicit-function-declaration]

SMP and Watchdog Timer Support are both disabled in this kernel configuration.

If additional information is necessary please ask.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#2 lore raw

[Bug 205303] Compilation for PPC64 fails on warning in watchdog.o

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=205303

A. Wilcox ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #2 from A. Wilcox ([email protected]) --- This is because CONFIG_HARDLOCK_DETECTOR is on and CONFIG_NMI_IPI is off.

CONFIG_HARDLOCK_DETECTOR pulls in CONFIG_PPC_WATCHDOG, which unconditionally uses smp_send_nmi_ipi (and I believe requires such to work properly). CONFIG_PPC_WATCHDOG doesn't depend on CONFIG_NMI_IPI which it probably should. And then CONFIG_HARDLOCK_DETECTOR_ARCH should probably depend on CONFIG_NMI_IPI or CONFIG_PPC_WATCHDOG.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#3 lore raw

[Bug 205303] Compilation for PPC64 fails on warning in watchdog.o

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=205303

Michael Ellerman ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
         Resolution|---                         |CODE_FIX

--- Comment #3 from Michael Ellerman ([email protected]) --- This was fixed by:

4fe529449d85 ("powerpc: Fix HAVE_HARDLOCKUP_DETECTOR_ARCH build configuration")

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.