New: usbip broken with latest kernels?

https://bugzilla.kernel.org/show_bug.cgi?id=208267

            Bug ID: 208267
           Summary: usbip broken with latest kernels?
           Product: Drivers
           Version: 2.5
    Kernel Version: Linux t420 5.7.4-arch1-1 #1 SMP PREEMPT Thu, 18 Jun
                    2020 16:01:07 +0000 x86_64 GNU/Linux
          Hardware: x86-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

[root@t420]: /home/docmax># usbip list -l
- busid 1-1.1 (0572:6831)
Conexant Systems (Rockwell), Inc. : DVBSky S960 DVB-S2 tuner (0572:6831)

- busid 1-1.2.3 (057e:0306)
Nintendo Co., Ltd : Wii Remote Controller RVL-003 (057e:0306)

- busid 1-1.2.4 (045e:0719)
Microsoft Corp. : Xbox 360 Wireless Adapter (045e:0719)

- busid 1-1.3 (147e:2016)
Upek : Biometric Touchchip/Touchstrip Fingerprint Sensor (147e:2016)

- busid 1-1.4 (0a5c:217f)
Broadcom Corp. : BCM2045B (BDC-2.1) (0a5c:217f)

- busid 1-1.6 (04f2:b221)
Chicony Electronics Co., Ltd : integrated camera (04f2:b221)

- busid 4-1 (152d:0567)
JMicron Technology Corp. / JMicron USA Technology Corp. : JMS567 SATA 6Gb/s
bridge (152d:0567)

- busid 4-2 (152d:0567)
JMicron Technology Corp. / JMicron USA Technology Corp. : JMS567 SATA 6Gb/s
bridge (152d:0567)

- busid 3-1.2 (174c:5136)
ASMedia Technology Inc. : ASM1053 SATA 3Gb/s bridge (174c:5136)

[root@t420]: /home/docmax># usbip -d bind -b 1-1.2.4
usbip: debug: usbip.c:129:[run_command] running command: `bind'
usbip: debug: sysfs_utils.c:24:[write_sysfs_attribute] error writing to attribute /sys/bus/usb/drivers/usbip-host/bind
usbip: error: error binding device 1-1.2.4 to driver: No such device
usbip: error: could not bind device to usbip-host

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #1 from DocMAX ([email protected]) --- Just found out: The problem begins with kernel 5.7!

You are receiving this mail because:
You are watching the assignee of the bug.

Does 5.6 work? Any chance you can use 'git bisect' to find the offending commit?

thanks,

greg k-h

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #2 from [email protected] ---

Does 5.6 work? Any chance you can use 'git bisect' to find the offending commit?

thanks,

greg k-h

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #3 from DocMAX ([email protected]) --- yes 5.6 works. as i said, starts with 5.7.
i haven't much experience with git bisect. need some guidance.

You are receiving this mail because:
You are watching the assignee of the bug.

the man page for git bisect should have lots of guidance, see
man git bisect
for the details.

To start, do:
git bisect start
git bisect good v5.6
git bisect bad v5.7
and then follow the prompts from there, building and booting the resulting kernel and saying 'good' or 'bad' depending on what happened.

If you have specific questions about this, please let us know.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #4 from Greg Kroah-Hartman ([email protected]) ---

the man page for git bisect should have lots of guidance, see
man git bisect
for the details.

To start, do:
git bisect start
git bisect good v5.6
git bisect bad v5.7
and then follow the prompts from there, building and booting the resulting kernel and saying 'good' or 'bad' depending on what happened.

If you have specific questions about this, please let us know.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

M. Vefa Bicakci ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #5 from M. Vefa Bicakci ([email protected]) --- Hello all,

I can confirm that reverting the following five commits resolves the reported issue with usbip, at least on Qubes OS, which uses usbip to redirect/reattach USB devices between VMs running on Xen.

* ef0f7d1877ac ("USB: Export generic USB device driver functions")
* c9d503370f24 ("USB: Make it possible to "subclass" usb_device_driver")
* aeebf2b54665 ("USB: Implement usb_device_match_id()")
* 88b7381a939d ("USB: Select better matching USB drivers when available")
* 77419aa403ca ("USB: Fallback to generic driver when specific driver fails")

Thank you,

Vefa

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

Jonathan Dieter ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #6 from Jonathan Dieter ([email protected]) --- FWIW, I've had this reported in Fedora as well:
https://bugzilla.redhat.com/show_bug.cgi?id=1856443

You are receiving this mail because:
You are watching the assignee of the bug.

Any chance someone can run 'git bisect' to find the offending commit?

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #7 from Greg Kroah-Hartman ([email protected]) ---

Any chance someone can run 'git bisect' to find the offending commit?

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #8 from Jonathan Dieter ([email protected]) ---
Sure, if commits in comment #5 aren't specific enough, I'll see if I can get a chance to run 'git bisect' this evening.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #9 from Jonathan Dieter ([email protected]) --- git bisect gives me the following:
88b7381a939de0fa1f1b1629c56b03dca7077309 is the first bad commit commit 88b7381a939de0fa1f1b1629c56b03dca7077309

Author: Bastien Nocera <[email protected]>
Date:   Wed Oct 16 11:39:31 2019 +0200

USB: Select better matching USB drivers when available

Now that USB device drivers can reuse code from the generic USB device driver, we need to make sure that they get selected rather than the generic driver. Add an id_table and match vfunc to the usb_device_driver struct, which will get used to select a better matching driver at ->probe time.

This is a similar mechanism to that used in the HID drivers, with the generic driver being selected unless there's a better matching one found in the registered drivers (see hid_generic_match() in drivers/hid/hid-generic.c).

 drivers/usb/core/driver.c  | 15 +++++++++++++--
 drivers/usb/core/generic.c | 29 +++++++++++++++++++++++++++++
 include/linux/usb.h        |  2 ++
 3 files changed, 44 insertions(+), 2 deletions(-)

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #10 from M. Vefa Bicakci ([email protected]) --- Hello all,

I just wanted to let all of the subscribers to this bug know that a patch that I prepared to resolve this issue was committed to Greg Kroah-Hartman's git tree for the USB subsystem. Sorry for the silence on my end.

Here is a link to the commit:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-linus&id=7a2f2974f26542b4e7b9b4321edb3cbbf3eeb91a

I had already verified that the linked patch resolves this bug with USB-IP on Qubes OS, but it would be beneficial/desirable for others to verify this.

I would also like to thank Jonathan Dieter for bisecting this issue to a specific commit, which was very helpful in preparing the committed patch.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

David Rohr ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #11 from David Rohr ([email protected]) ---
I just compiled 5.8.5 with your patch and usbip works correctly, thx!

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #12 from DocMAX ([email protected]) ---
Just a side-question: Can things like this happen on LTS versions of the kernel?

You are receiving this mail because:
You are watching the assignee of the bug.

"things" like what?

Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

for the rules of what type of patches are allowed in the stable kernel trees.

thanks,

greg k-h

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #14 from DocMAX ([email protected]) ---
things = breaking functionality of well known programs that are even integrated in the kernel.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #13 from Greg Kroah-Hartman ([email protected]) ---

"things" like what?

Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

for the rules of what type of patches are allowed in the stable kernel trees.

thanks,

greg k-h

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #15 from Greg Kroah-Hartman ([email protected]) ---

Bugs happen, we are human :)

You are receiving this mail because:
You are watching the assignee of the bug.

Bugs happen, we are human :)

https://bugzilla.kernel.org/show_bug.cgi?id=208267

--- Comment #16 from M. Vefa Bicakci ([email protected]) --- Hello David,

I realize that this is a bit late, but thanks for the feedback confirming that USB-IP functionality is restored with the patch!

Hello Greg and DocMAX,

Given that Greg has recently released Linux v5.8.6 with the commit fixing this issue (thanks!), would it be possible for one of you to close this bug? (Sorry making this administration request; I logged in with the intention of closing this bug, but it appears that I do not have the permission to do so.)

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=208267

Greg Kroah-Hartman ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
         Resolution|---                         |CODE_FIX

You are receiving this mail because:
You are watching the assignee of the bug.