Skip to contentSkip to conversation

KASAN: Use-after-free bug in xlog_alloc_log

Bug 208751 [email protected] 1 participant 1 message Jul 31, 2020 1 message not in the archive

lore
Share & tools
lore

[email protected]

author Reviewed-by Darrick J. Wong
#1 lore raw
In reply to a message not in the archive

https://bugzilla.kernel.org/show_bug.cgi?id=208751

Eric Sandeen ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
         Resolution|---                         |PATCH_ALREADY_AVAILABLE

--- Comment #1 from Eric Sandeen ([email protected]) ---
You've reported this on a 5.4.0 kernel from November 2019 (please, in future bug reports include the kernel version more prominently)

This commit:

commit 798a9cada4694ca8d970259f216cec47e675bfd5

Author: Brian Foster <[email protected]>
Date:   Tue Dec 3 07:53:15 2019 -0800

xfs: fix mount failure crash on invalid iclog memory access

syzbot (via KASAN) reports a use-after-free in the error path of xlog_alloc_log(). Specifically, the iclog freeing loop doesn't handle the case of a fully initialized ->l_iclog linked list. Instead, it assumes that the list is partially constructed and NULL terminated.

This bug manifested because there was no possible error scenario after iclog list setup when the original code was added. Subsequent code and associated error conditions were added some time later, while the original error handling code was never updated. Fix up the error loop to terminate either on a NULL iclog or reaching the end of the list.

went into v5.5

I believe this is already resolved; if you have a reproducer can you please test? If you believe this bug is still not fixed, please re-open this bug.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.