USB 3.1 device cannot be detected
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #1 from Walt Jr. Brake ([email protected]) ---
Yesterday I try to fix it myself, and after I revert the patch [usb: core:
reduce power-on-good delay time of root hub](https://lore.kernel.org/all/1618017645-12259-1-git-send-email-chunfeng.yun%40mediatek.com/), compile the kernel and test, it works.
Here is the patch:
drivers/usb/core/hub.h +0 -0
@@ -148,10 +148,8 @@ static inline unsigned hub_power_on_good_delay(struct
usb_hub *hub)
{
unsigned delay = hub->descriptor->bPwrOn2PwrGood * 2;- if (!hub->hdev->parent) /* root hub */
- return delay;
- else /* Wait at least 100 msec for power to become stable */
- return max(delay, 100U);
+ /* Wait at least 100 msec for power to become stable */
+ return max(delay, 100U);
}
static inline int hub_port_debounce_be_connected(struct usb_hub *hub,
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #2 from Walt Jr. Brake ([email protected]) --- correct the patch display format
```
diff --git a/drivers/usb/core/hub.h b/drivers/usb/core/hub.h
index 22ea1f4f2d66..73f4482d833a 100644
--- a/drivers/usb/core/hub.h
+++ b/drivers/usb/core/hub.h
@@ -148,10 +148,8 @@ static inline unsigned hub_power_on_good_delay(struct
usb_hub *hub)
{
unsigned delay = hub->descriptor->bPwrOn2PwrGood * 2;
- if (!hub->hdev->parent) /* root hub */
- return delay;
- else /* Wait at least 100 msec for power to become stable */
- return max(delay, 100U);
+ /* Wait at least 100 msec for power to become stable */
+ return max(delay, 100U);
}
static inline int hub_port_debounce_be_connected(struct usb_hub *hub,
```Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=214875
Walt Jr. Brake ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |PATCH_ALREADY_AVAILABLE--- Comment #4 from Walt Jr. Brake ([email protected]) ---
It was fixed by the patch [xhci: Fix USB 3.1 enumeration issues by increasing roothub power-on-good delay](https://lore.kernel.org/all/[email protected]/)
Thanks for your works.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=214875
Michele Tucci ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #5 from Michele Tucci ([email protected]) --- My USB 3 external hard drive cannot be detected after this fix.
To get it working again, I restored to 10 (20ms) the value of desc->bPwrOn2PwrGood in drivers/usb/host/xhci-hub.c:347.
This is how the device looks like from lsusb:
``` Bus 004 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E ... ```
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #6 from Walt Jr. Brake ([email protected]) --- (In reply to Michele Tucci from comment #5)
Quoted 9 lines
My USB 3 external hard drive cannot be detected after this fix.
To get it working again, I restored to 10 (20ms) the value of
desc->bPwrOn2PwrGoodindrivers/usb/host/xhci-hub.c:347.This is how the device looks like from lsusb:
``` Bus 004 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E ... ```
Maybe you should using the reply to instructions from
https://lore.kernel.org/all/1618017645-12259-1-git-send-email-chunfeng.yun%40mediatek.com/
to raise the issue on the linux-usb mailing list.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #7 from Chunfeng Yun ([email protected]) --- (In reply to Michele Tucci from comment #5)
Quoted 9 lines
My USB 3 external hard drive cannot be detected after this fix.
To get it working again, I restored to 10 (20ms) the value of
desc->bPwrOn2PwrGoodindrivers/usb/host/xhci-hub.c:347.This is how the device looks like from lsusb:
``` Bus 004 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E ... ```
Then will be reproduced if revert below patch?
https://lore.kernel.org/all/1618017645-12259-1-git-send-email-chunfeng.yun%40mediatek.com/
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.