New: mvsas not detecting some disks
https://bugzilla.kernel.org/show_bug.cgi?id=214967
Bug ID: 214967
Summary: mvsas not detecting some disks
Product: SCSI Drivers
Version: 2.5
Kernel Version: 5.15.x
Hardware: Intel
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
Assignee: [email protected]
Reporter: [email protected]
Regression: NoCreated attachment 299493
--> https://bugzilla.kernel.org/attachment.cgi?id=299493&action=edit
Kernel log
mvsas module fails to IDENTIFY some disks on RocketRaid 2744. Started happening with 5.15.0, continues with 5.15.1.
Excerpt from kernel log attached.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #1 from Matthew Perkowski ([email protected]) ---
I stumbled across this and gave it a try, and it fixed my immediate problem:
https://sourceforge.net/p/scst/mailman/scst-devel/thread/[email protected]/
However, it doesn't look like the mvsas driver has changed in some time, so I'm thinking the problem was caused by another change somewhere else in the kernel, and adding that one line of code to mv_sas.c simply "band-aided" the immediate issue I was experiencing.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
Bart Van Assche ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #2 from Bart Van Assche ([email protected]) --- It would help a lot if this issue would be bisected. See also
https://www.kernel.org/doc/html/latest/admin-guide/bug-bisect.html.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #3 from Matthew Perkowski ([email protected]) ---
Oh, that's an excellent point. I will try to do so as soon as I can and provide further information.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #4 from Matthew Perkowski ([email protected]) --- Bisection has identified commit 2360fa1812cd77e1de13d3cca789fbd23462b651 as the origin of the issue.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #5 from Bart Van Assche ([email protected]) ---
Quoted 6 lines · On 11/15/21 2:34 PM, [email protected] wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #4 from Matthew Perkowski ([email protected]) --- Bisection has identified commit
2360fa1812cd77e1de13d3cca789fbd23462b651as the
origin of the issue.
This commit: 2360fa1812cd ("libata: cleanup NCQ priority handling")?
Damien, can you take a look?
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
Damien Le Moal ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #6 from Damien Le Moal ([email protected]) --- (In reply to Bart Van Assche from comment #5)
Quoted 7 lines · On 11/15/21 2:34 PM, [email protected] wrote:
Quoted 6 lines
https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #4 from Matthew Perkowski ([email protected]) --- Bisection has identified commit
2360fa1812cd77e1de13d3cca789fbd23462b651as the
origin of the issue.
Hmm... It seems very strange that this patch creates the problem. Even with a bug, the worst that could happen is failing to detect NCQ priority support.
The problem is likely related to the errors "ata14.00: Read log page 0x08 failed, Emask 0x1" which come from the kernel trying to access a non existent log page (IDENTIFY DEVICE data log), which is tried when probing for NCQ priority support.
libata ignores this error, not enabling the feature that was being probed. The mvsas driver may not.
I posted a patch yesterday to prevent such access to log pages not supported by the device. See:
https://lore.kernel.org/linux-ide/[email protected]/
Can you try these ?
Quoted 4 lines
This commit:
2360fa1812cd("libata: cleanup NCQ priority handling")?Damien, can you take a look?
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #7 from Damien Le Moal ([email protected]) --- (In reply to Matthew Perkowski from comment #1)
Quoted 9 lines
I stumbled across this and gave it a try, and it fixed my immediate problem:
https://sourceforge.net/p/scst/mailman/scst-devel/thread/4FDDA78C.400@acm.
org/However, it doesn't look like the mvsas driver has changed in some time, so I'm thinking the problem was caused by another change somewhere else in the kernel, and adding that one line of code to
mv_sas.csimply "band-aided" the immediate issue I was experiencing.
I am not familiar with the mv_sas driver & associated HBAs. Do these implement SAT using libata on the host ? Or does the HBA firmware handle scsi command translation ? Some quick grep in the driver code does not reveal much.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #8 from Matthew Perkowski ([email protected]) --- (In reply to Damien Le Moal from comment #6)
Quoted 21 lines
(In reply to Bart Van Assche from comment #5)
Quoted 5 lines · On 11/15/21 2:34 PM, [email protected] wrote:
Quoted 4 lines
https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #4 from Matthew Perkowski ([email protected]) --- Bisection has identified commit
2360fa1812cd77e1de13d3cca789fbd23462b651as
Quoted 2 lines
Quoted 2 lines
the
origin of the issue.Hmm... It seems very strange that this patch creates the problem. Even with a bug, the worst that could happen is failing to detect NCQ priority support.
The problem is likely related to the errors "ata14.00: Read log page
0x08failed, Emask0x1" which come from the kernel trying to access a non existent log page (IDENTIFY DEVICE data log), which is tried when probing for NCQ priority support.libata ignores this error, not enabling the feature that was being probed. The mvsas driver may not.
Quoted 13 lines
I posted a patch yesterday to prevent such access to log pages not supported by the device. See:
https://lore.kernel.org/linux-ide/20211115060559.232835-1-damien.
[email protected]/Can you try these ?
Quoted 4 lines
This commit:
2360fa1812cd("libata: cleanup NCQ priority handling")?Damien, can you take a look?
I will try rebuilding with the patches at my first opportunity and report back.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #9 from Matthew Perkowski ([email protected]) --- (In reply to Damien Le Moal from comment #7)
Quoted 10 lines
(In reply to Matthew Perkowski from comment #1)
Quoted 1 line
I stumbled across this and gave it a try, and it fixed my immediate
problem:
Quoted 7 lines
https://sourceforge.net/p/scst/mailman/scst-devel/thread/4FDDA78C.400@acm.
org/However, it doesn't look like the mvsas driver has changed in some time, so I'm thinking the problem was caused by another change somewhere else in the kernel, and adding that one line of code to
mv_sas.csimply "band-aided"
Quoted 7 lines
the
Quoted 1 line
immediate issue I was experiencing.
I am not familiar with the
mv_sasdriver & associated HBAs. Do these implement SAT using libata on the host ? Or does the HBA firmware handle scsi command translation ? Some quick grep in the driver code does not reveal much.
I'm afraid I don't know that for certain. I know the card HAS firmware since I've updated it once before. I'll see if those patches solve the problem. If not, maybe I can figure out more about the card to help us along. I can tell you that the card uses this controller chip:
I'm not accustomed to interpreting hardware information at such a low level myself, but it mentions offering "native 6Gb/s SATA interface support."
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #10 from Damien Le Moal ([email protected]) --- (In reply to Matthew Perkowski from comment #9)
Quoted 27 lines
(In reply to Damien Le Moal from comment #7)
Quoted 5 lines
(In reply to Matthew Perkowski from comment #1)
Quoted 1 line
I stumbled across this and gave it a try, and it fixed my immediate
problem:
Quoted 2 lines
https://sourceforge.net/p/scst/mailman/scst-devel/thread/4FDDA78C.400@acm.
Quoted 3 lines
Quoted 3 lines
org/
However, it doesn't look like the mvsas driver has changed in some time,
so
Quoted 1 line
Quoted 1 line
I'm thinking the problem was caused by another change somewhere else in
the
Quoted 8 lines
Quoted 1 line
kernel, and adding that one line of code to
mv_sas.csimply "band-aided"the
Quoted 1 line
immediate issue I was experiencing.
I am not familiar with the
mv_sasdriver & associated HBAs. Do these implement SAT using libata on the host ? Or does the HBA firmware handle scsi command translation ? Some quick grep in the driver code does not reveal much.I'm afraid I don't know that for certain. I know the card HAS firmware since I've updated it once before. I'll see if those patches solve the problem. If not, maybe I can figure out more about the card to help us along. I can tell you that the card uses this controller chip:
Quoted 5 lines
https://www.marvell.com/content/dam/marvell/en/public-collateral/storage/
marvell-storage-88se94xx-product-brief-2011-04.pdfI'm not accustomed to interpreting hardware information at such a low level myself, but it mentions offering "native 6Gb/s SATA interface support."
Looks like the mvsas driver uses libsas, so it likely relies on libata for SCSI-to-ATA translation. Will have a closer look. I also have other HBAs using the pm80xx driver that is similar. Will do some more tests with that.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #11 from Damien Le Moal ([email protected]) --- (In reply to Matthew Perkowski from comment #8)
Quoted 35 lines
(In reply to Damien Le Moal from comment #6)
Quoted 6 lines
(In reply to Bart Van Assche from comment #5)
Quoted 5 lines · On 11/15/21 2:34 PM, [email protected] wrote:
Quoted 4 lines
https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #4 from Matthew Perkowski ([email protected]) --- Bisection has identified commit
2360fa1812cd77e1de13d3cca789fbd23462b651Quoted 6 lines
as
Quoted 2 lines
Quoted 2 lines
the
origin of the issue.Hmm... It seems very strange that this patch creates the problem. Even with a bug, the worst that could happen is failing to detect NCQ priority
support.
Quoted 10 lines
The problem is likely related to the errors "ata14.00: Read log page
0x08failed, Emask0x1" which come from the kernel trying to access a non existent log page (IDENTIFY DEVICE data log), which is tried when probing for NCQ priority support.libata ignores this error, not enabling the feature that was being probed. The mvsas driver may not.
I posted a patch yesterday to prevent such access to log pages not
supported
Quoted 9 lines
by the device. See:
https://lore.kernel.org/linux-ide/20211115060559.232835-1-damien.
[email protected]/Can you try these ?
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
This commit:
2360fa1812cd("libata: cleanup NCQ priority handling")?Damien, can you take a look?
I will try rebuilding with the patches at my first opportunity and report back.
That would be great. Thanks.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #12 from Matthew Perkowski ([email protected]) --- (In reply to Damien Le Moal from comment #11)
Quoted 38 lines
(In reply to Matthew Perkowski from comment #8)
Quoted 13 lines
(In reply to Damien Le Moal from comment #6)
Quoted 6 lines
(In reply to Bart Van Assche from comment #5)
Quoted 5 lines · On 11/15/21 2:34 PM, [email protected] wrote:
Quoted 4 lines
https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #4 from Matthew Perkowski ([email protected]) --- Bisection has identified commit
2360fa1812cd77e1de13d3cca789fbd23462b651Quoted 5 lines
as
Quoted 2 lines
Quoted 2 lines
the
origin of the issue.Hmm... It seems very strange that this patch creates the problem. Even
with
Quoted 9 lines
Quoted 1 line
a bug, the worst that could happen is failing to detect NCQ priority
support.
Quoted 7 lines
The problem is likely related to the errors "ata14.00: Read log page
0x08failed, Emask0x1" which come from the kernel trying to access a non existent log page (IDENTIFY DEVICE data log), which is tried when probing for NCQ priority support.libata ignores this error, not enabling the feature that was being
probed.
Quoted 13 lines
Quoted 3 lines
The mvsas driver may not.
I posted a patch yesterday to prevent such access to log pages not
supported
Quoted 9 lines
by the device. See:
https://lore.kernel.org/linux-ide/20211115060559.232835-1-damien.
[email protected]/Can you try these ?
Quoted 1 line
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
This commit:
2360fa1812cd("libata: cleanup NCQ priority handling")?Damien, can you take a look?
I will try rebuilding with the patches at my first opportunity and report back.
That would be great. Thanks.
Looks like your hunch may have been right on. I applied your patches to a fresh copy of the 5.15.2 source (which was not working properly with my RR 2744 card via the mvsas driver in vanilla form), and the issue did not arise when I booted into it.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[email protected]
Tested-by Matthew Perkowski[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #13 from Damien Le Moal ([email protected]) --- (In reply to Matthew Perkowski from comment #12)
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
I will try rebuilding with the patches at my first opportunity and report back.
That would be great. Thanks.
Looks like your hunch may have been right on. I applied your patches to a fresh copy of the 5.15.2 source (which was not working properly with my RR 2744 card via the mvsas driver in vanilla form), and the issue did not arise when I booted into it.
Great. Can I add your Tested-by tag ?
E.g.:
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #14 from Matthew Perkowski ([email protected]) --- (In reply to Damien Le Moal from comment #13)
Quoted 10 lines
(In reply to Matthew Perkowski from comment #12)
Quoted 1 line
Quoted 1 line
Quoted 1 line
I will try rebuilding with the patches at my first opportunity and
report
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
back.
That would be great. Thanks.
Looks like your hunch may have been right on. I applied your patches to a fresh copy of the 5.15.2 source (which was not working properly with my RR 2744 card via the mvsas driver in vanilla form), and the issue did not
Quoted 7 lines
arise
Quoted 1 line
when I booted into it.
Great. Can I add your Tested-by tag ?
E.g.:Tested-by Matthew Perkowski <[email protected]>
Certainly. That is fine with me.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #15 from Damien Le Moal ([email protected]) --- (In reply to Matthew Perkowski from comment #14)
Quoted 13 lines
(In reply to Damien Le Moal from comment #13)
Quoted 9 lines
(In reply to Matthew Perkowski from comment #12)
Quoted 1 line
Quoted 1 line
Quoted 1 line
I will try rebuilding with the patches at my first opportunity and
report
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
back.
That would be great. Thanks.
Looks like your hunch may have been right on. I applied your patches to a fresh copy of the 5.15.2 source (which was not working properly with my
RR
Quoted 2 lines
Quoted 1 line
2744 card via the mvsas driver in vanilla form), and the issue did not
arise
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
when I booted into it.
Great. Can I add your Tested-by tag ?
E.g.:Tested-by Matthew Perkowski <[email protected]>Certainly. That is fine with me.
Could you test with the latest 5.16-rc1 kernel too please ?
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #16 from Matthew Perkowski ([email protected]) --- (In reply to Damien Le Moal from comment #15)
Quoted 1 line
Could you test with the latest 5.16-rc1 kernel too please ?
Built, patched, and tested with 5.16-rc1. mvsas detected all drives as expected. Scanned the kernel log after boot to check more in-depth as well. No unusual messages from the mvsas driver. Seems to be working exactly as I would expect.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
--- Comment #17 from Damien Le Moal ([email protected]) --- (In reply to Matthew Perkowski from comment #16)
Quoted 7 lines
(In reply to Damien Le Moal from comment #15)
Quoted 1 line
Could you test with the latest 5.16-rc1 kernel too please ?
Built, patched, and tested with 5.16-rc1. mvsas detected all drives as expected. Scanned the kernel log after boot to check more in-depth as well. No unusual messages from the mvsas driver. Seems to be working exactly as I would expect.
Great ! Thanks for testing.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
Matthew Perkowski ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |CODE_FIXSignature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 214967] mvsas not detecting some disks
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=214967
Andy Zhu ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #18 from Andy Zhu ([email protected]) --- Created attachment 307503
--> https://bugzilla.kernel.org/attachment.cgi?id=307503&action=edit
Resurface the bug -- 1/17/2025
I encountered a similar issue with the initial report back in 2021.
I tried to revive my old workstation which has BIOS/MBR with 5 HDD slots. However, Arch linux can only detect 2 of the disks. BIOS can see all the HDDs. Linux kernel is: 6.6.72-1-lts and updated system with pacman -Syu. attached my journalctl output here.
First time to post, not sure what posting policy/requirement. Thanks for any help in advance.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.