Skip to contentSkip to conversation

New: Incorrect path name in description of creating a threaded cgroups tree

Bug 218105 [email protected] 1 participant 4 messages Nov 5, 2023 – Mar 4, 2024 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=218105

Bug ID: 218105
Summary: Incorrect path name in description of creating a
threaded cgroups tree
Product: Documentation
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P3
Component: man-pages
Assignee: [email protected]
Reporter: [email protected]
Regression: No

The manual page for cgroups.7 explains how to create a threaded subtree in this way:

1. In an existing cgroup, z, that currently has the type domain, we (1) enable one or more threaded controllers and (2) make a process a
member of z. (These two steps can be done in either order.) This
has the following consequences:

* The type of z becomes domain threaded.

* All of the descendant cgroups of x that were not already of type threaded are converted to type domain invalid.

Where the last bullet talks about "x", it should surely talk about "z".

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#1 lore raw

[Bug 218105] Incorrect path name in description of creating a threaded cgroups tree

https://bugzilla.kernel.org/show_bug.cgi?id=218105

Alejandro Colomar ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #1 from Alejandro Colomar ([email protected]) --- It seems it affects more text:

The second way of creating a threaded subtree is as follows:

(1) In an existing cgroup, z, that currently has the type do‐ main, we (1.1) enable one or more threaded controllers and (1.2) make a process a member of z. (These two steps can be done in either order.) This has the following consequences:

• The type of z becomes domain threaded.

• All of the descendant cgroups of x that were not already of type threaded are converted to type domain invalid.

(2) As before, we make the threaded subtree usable by writing the string "threaded" to each of the domain invalid cgroups under y, in order to convert them to the type threaded.

The 'y' in (2) also seems like it should have been 'z'. Do you agree?

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#3 lore raw

[Bug 218105] Incorrect path name in description of creating a threaded cgroups tree

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=218105

Alejandro Colomar ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #3 from Alejandro Colomar ([email protected]) --- I'll push the following commit tomorrow. Thanks for the report!

commit 09ed04875f27741e4ad111d7bcc5e93a5397903f (HEAD -> contrib, alx/contrib)

Author: Alejandro Colomar <[email protected]>
Date:   Mon Mar 4 12:45:24 2024 +0100

cgroups.7: tfix

man7/cgroups.7 +2 -2
index ca10cf859..877aae03f 100644
@@ -1441,7 +1441,7 @@ .SS Creating a threaded subtree
 .IR "domain threaded" .
 .IP \[bu]
 All of the descendant cgroups of
-.I x
+.I z
 that were not already of type
 .I threaded
 are converted to type
@@ -1453,7 +1453,7 @@ .SS Creating a threaded subtree
 to each of the
 .I domain invalid
 cgroups under
-.IR y ,
+.IR z ,
 in order to convert them to the type
 .IR threaded .
 .P
Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.