Skip to contentSkip to conversation

New: [BISECTED[ UCSI patch breaks lunar lake boot on 6.13-rc1

Bug 219562 [email protected] 1 participant 4 messages Dec 4, 2024 – Feb 7, 2025 USB

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=219562

            Bug ID: 219562
           Summary: [BISECTED[ UCSI patch breaks lunar lake boot on
                    6.13-rc1
           Product: Drivers
           Version: 2.5
    Kernel Version: 6.13-rc1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: high
          Priority: P3
         Component: USB
          Assignee: [email protected]
          Reporter: [email protected]
            Blocks: 178231
        Regression: Yes
           Bisected 226ff2e681d006eada59a9693aa1976d4c15a7d4
         commit-id:

Created attachment 307321
--> https://bugzilla.kernel.org/attachment.cgi?id=307321&action=edit
otcpl-lnl-m-9-bad-commit-console-log.txt

Our lunar lake machines are not booting as of 6.13-rc1. I've bisectedf it to this commit:

commit 226ff2e681d006eada59a9693aa1976d4c15a7d4 (refs/bisect/bad)

Author: Heikki Krogerus <[email protected]>
Date:   Wed Nov 6 17:06:05 2024 +0200

usb: typec: ucsi: Convert connector specific commands to bitmaps

That allows the fields in those command data structures to be easily validated. If an unsupported field is accessed, a warning is generated.

This will not force UCSI version checks to be made in every place where these data structures are accessed, but it will make it easier to pinpoint issues that are caused by the unconditional accesses to those fields, and perhaps more importantly, allow those issues to be noticed immediately.

Link:
https://lore.kernel.org/r/[email protected]

I've attached the console output of the fail

Referenced Bugs:

https://bugzilla.kernel.org/show_bug.cgi?id=178231
[Bug 178231] Meta-bug: Linux suspend-to-mem and freeze performance optimization

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#1 lore raw

[Bug 219562] [BISECTED] UCSI patch breaks lunar lake boot on 6.13-rc1

https://bugzilla.kernel.org/show_bug.cgi?id=219562

--- Comment #1 from Todd Brandt ([email protected]) --- I've seen a potential fix patch on the mailing list:

https://lore.kernel.org/linux-usb/[email protected]/

I've just tested it it and it appears to work.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#2 lore raw

[Bug 219562] [BISECTED] UCSI patch breaks lunar lake boot on 6.13-rc1

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219562

Stefan Fleischmann ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #2 from Stefan Fleischmann ([email protected]) ---
I can confirm the problem. My machine (Asus Expertbook laptop) can still boot but I see several of these protection faults in the kernel log, and it cannot detect the battery status or shut down properly.

The patch works for me too.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
#3 lore raw

[Bug 219562] [BISECTED] UCSI patch breaks lunar lake boot on 6.13-rc1

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=219562

Todd Brandt ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX
Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.