Skip to contentSkip to conversation

k8-powernow does not see all cores

Bug 24562 [email protected] 1 participant 3 messages Dec 14, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

#1 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=24562

Zhang Rui <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

          Component|Config-Processors           |cpufreq
         AssignedTo|acpi_config-processors@kern |[email protected]
                   |el-bugs.osdl.org            |
            Product|ACPI                        |Power Management

--- Comment #10 from Zhang Rui <[email protected]> 2010-12-14 00:22:49 --- oh, sorry, I rechecked the code and it seems that the first "0,1,2,3" is not redundant information.
Reassign this bug to cpufreq driver experts.

Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
#3 lore raw
In reply to a message not in the archive

https://bugzilla.kernel.org/show_bug.cgi?id=24562

Thomas Renninger <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEEDINFO                    |RESOLVED
                 CC|                            |[email protected]
         Resolution|                            |CODE_FIX
         AssignedTo|[email protected]     |[email protected]

--- Comment #12 from Thomas Renninger <[email protected]> 2010-12-14 11:26:22 ---

Quoted 2 lines

This is confusing, this can be read as: core 0, currently on 3200 MHz, core 1 currently on 2400 MHz, etc, with cores 4 and 5 not seen.

I expect you mean the new message on "boostable" CPUs which is unrelated to the rest:

Quoted 1 line

powernow-k8: Core Performance Boosting: on.

can get mixed up with below:

Quoted 2 lines
powernow-k8:    0 : pstate 0 (3200 MHz)
powernow-k8:    1 : pstate 1 (2400 MHz)

especially the "Core performance" string by bad luck looks related:
Core Performance
0 : pstate 0
1 : pstate 1

I agree that this is a bit confusing and Rui's first part of the patch should be sufficient:

             if (cpu_family == CPU_HW_PSTATE) {
                 printk(KERN_INFO PFX
-                    "   %d : pstate %d (%d MHz)\n", j,
+                    "   pstate %d (%d MHz)\n",
                     data->powernow_table[j].index,
                     data->powernow_table[j].frequency/1000);

In the other case this message:

Quoted 1 line

powernow-k8: Core Performance Boosting: on.

doesn't appear anyway and the message has another format and the bit removed by Rui has some meaning.

But this is a really minor bug.
I hope I do not forget about it and I will add Rui's first part if I have other cpufreq patches in the queue -> I set this one resolved already.

Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.