Ixgbe driver does not ensure FWSM firmware mode is valid before using it

https://dpdk.org/tracker/show_bug.cgi?id=26

Bug ID: 26
Summary: Ixgbe driver does not ensure FWSM firmware mode is
valid before using it
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---

The Intel 82599 data sheet
(https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82599-10-gbe-controller-datasheet.pdf,
§8.2.3.4.10) states of the FWSM register's bit 15 (FW_Val_bit) that "Hardware clears this bit in reset de-assertion so software can know firmware mode (bits 1-5) is invalid".

However, the ixgbe driver does not check that bit before using the firmware mode, e.g. in ixgbe_mng_present
(http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/base/ixgbe_common.c?h=v18.02#n5194).

You are receiving this mail because:
You are the assignee for the bug.