Skip to contentSkip to conversation

New: r6040: interface status messaged logged once per second

Bugme-new Andrew Morton 1 participant 1 message Feb 14, 2011 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 57 lines · On Mon, 14 Feb 2011 19:39:50 GMT [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=29122

           Summary: r6040: interface status messaged logged once per
                    second
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.35.10
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Network
        AssignedTo: [email protected]
        ReportedBy: [email protected]
        Regression: No

In the following patch by Florian Fainelli - 2010-05-16, the added call to mii_check_media() has the "printit" flag, the 2nd parameter, set which causes a status message to be logged once per second.

drivers/net/r6040.c +3 -5
index 4122916..eeee379 100644
@@ -400,9 +400,6 @@  static void r6040_init_mac_regs(struct net_device *dev)
      * we may got called by r6040_tx_timeout which has left
      * some unsent tx buffers */
     iowrite16(0x01, ioaddr + MTPR);
-
-    /* Check media */
-    mii_check_media(&lp->mii_if, 1, 1);
 }
 
 static void r6040_tx_timeout(struct net_device *dev)
@@ -530,8 +527,6 @@  static int r6040_phy_mode_chk(struct net_device *dev)
             phy_dat = 0x0000;
     }
 
-    mii_check_media(&lp->mii_if, 0, 1);
-
     return phy_dat;
 };
 
@@ -813,6 +808,9 @@  static void r6040_timer(unsigned long data)
 
     /* Timer active again */
     mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
+
+    /* Check media */
+    mii_check_media(&lp->mii_if, 1, 1);
 }
 
 /* Read/set MAC address routines */