Skip to contentSkip to conversation

New: IPv6 doesn't work in a kvm guest.

Bugme-new Andrew Morton 3 participants 7 messages Feb 17, 2011 – Mar 11, 2011 1 message not in the archive

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

Andrew Morton

author
#1 lore raw

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 41 lines · On Wed, 16 Feb 2011 13:03:15 GMT [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=29252

           Summary: IPv6 doesn't work in a kvm guest.
           Product: Networking
           Version: 2.5
    Kernel Version: 2.6.38-rc5
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: IPV6
        AssignedTo: [email protected]
        ReportedBy: [email protected]
        Regression: Yes

apt-get and ping6 don't work in a kvm guest. It appears that neighbor discovery is not working. I'm using tap, virtio-net and vhost. I did bisect and results is

d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4 is the first bad commit commit d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4

Author: David S. Miller <[email protected]>
Date:   Mon Jan 24 16:01:58 2011 -0800

ipv6: Always clone offlink routes.

Do not handle PMTU vs. route lookup creation any differently wrt. offlink routes, always clone them.

Reported-by PK <[email protected]>
Signed-off-by David S. Miller <[email protected]>

:040000 040000 c4a34e9e36bd8cc81e898738f2d4344f6647d472f0fcd4b093ec22784798f3951203391f4567b278
M net

reverting this commit for guest kernel fixes the probrem.

maintainer
#2 lore raw

From: Andrew Morton <[email protected]>
Date: Thu, 17 Feb 2011 14:25:17 -0800

Quoted 1 line
Quoted 1 line

https://bugzilla.kernel.org/show_bug.cgi?id=29252

...

Quoted 14 lines
Quoted 14 lines

apt-get and ping6 don't work in a kvm guest. It appears that neighbor discovery is not working. I'm using tap, virtio-net and vhost. I did bisect and results is

d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4 is the first bad commit commit d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4

Author: David S. Miller <[email protected]>
Date:   Mon Jan 24 16:01:58 2011 -0800

ipv6: Always clone offlink routes.

Do not handle PMTU vs. route lookup creation any differently wrt. offlink routes, always clone them.

Quoted 8 lines
Quoted 8 lines
Reported-by PK <[email protected]>
Signed-off-by David S. Miller <[email protected]>

:040000 040000 c4a34e9e36bd8cc81e898738f2d4344f6647d472f0fcd4b093ec22784798f3951203391f4567b278
M net

reverting this commit for guest kernel fixes the probrem.

Thanks for the report, I'll look into this.

maintainer
#3 lore raw
In reply to Andrew Morton

Ok, the following should address both bugs, #29252 and #30462, please give it some testing.

--------------------
ipv6: Don't create clones of nonexthop routes forever.

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=29252
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=30462

In commit d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4 ("ipv6: Always clone offlink routes.") we forced the kernel to always clone offlink routes.

The reason we do that is to make sure we never bind an inetpeer to a prefixed route.

The logic turned on here has existed in the tree for many years, but was always off due to a protecting CPP define. So perhaps it's no surprise that there is a logic bug here.

The issue is that there is nothing that stops the cloning process. Every route call will find the same route in the same condition, reclone it, and insert.

This causes two problems:

1) If the in6_rt_ins() call succeeds, we get tons of crap in the routing tree.

2) If the int6_rt_ins() call fails, we get no networking to that destination.

We've had reports of both cases.

End the loop and the failures by keying on the RTF_CACHE flag which will only be set in the clone routes.

Reported-by [email protected]
Reported-by Ernst Sjöstrand <[email protected]>
Signed-off-by David S. Miller <[email protected]>
net/ipv6/route.c +3 -1
index 904312e..8963635 100644
@@ -739,8 +739,10 @@ restart:
 
 	if (!rt->rt6i_nexthop && !(rt->rt6i_flags & RTF_NONEXTHOP))
 		nrt = rt6_alloc_cow(rt, &fl->fl6_dst, &fl->fl6_src);
-	else
+	else if (!(rt->rt6i_flags & RTF_CACHE))
 		nrt = rt6_alloc_clone(rt, &fl->fl6_dst);
+	else
+		goto out2;
 
 	dst_release(&rt->dst);
 	rt = nrt ? : net->ipv6.ip6_null_entry;
maintainer
#4 lore raw

From: David Miller <[email protected]>
Date: Wed, 09 Mar 2011 15:58:18 -0800 (PST)

Quoted 5 lines

Ok, the following should address both bugs, #29252 and #30462, please give it some testing.

--------------------
ipv6: Don't create clones of nonexthop routes forever.

Nevermind, this patch has problems, I'm still debugging and trying to come up with a proper fix.

Thanks in advance for your patience.

maintainer
#5 lore raw

From: David Miller <[email protected]>
Date: Wed, 09 Mar 2011 19:20:12 -0800 (PST)

Quoted 6 lines

From: David Miller <[email protected]>
Date: Wed, 09 Mar 2011 15:58:18 -0800 (PST)

Quoted 3 lines

Ok, the following should address both bugs, #29252 and #30462, please give it some testing.

Quoted 7 lines
Quoted 2 lines

--------------------
ipv6: Don't create clones of nonexthop routes forever.

Nevermind, this patch has problems, I'm still debugging and trying to come up with a proper fix.

Thanks in advance for your patience.

Ok, I'm more confident in this version of the fix. It passes all of my tests, and I've added instrumentation to make sure various cases are performing the operations the way I expect them to.

--------------------
ipv6: Don't create clones of host routes.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=29252
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=30462

In commit d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4 ("ipv6: Always clone offlink routes.") we forced the kernel to always clone offlink routes.

The reason we do that is to make sure we never bind an inetpeer to a prefixed route.

The logic turned on here has existed in the tree for many years, but was always off due to a protecting CPP define. So perhaps it's no surprise that there is a logic bug here.

The problem is that we canot clone a route that is already a host route (ie. has DST_HOST set). Because if we do, an identical entry already exists in the routing tree and therefore the ip6_rt_ins() call is going to fail.

This sets off a series of failures and high cpu usage, because when ip6_rt_ins() fails we loop retrying this operation a few times in order to handle a race between two threads trying to clone and insert the same host route at the same time.

Fix this by simply using the route as-is when DST_HOST is set.

Reported-by [email protected]
Reported-by Ernst Sjöstrand <[email protected]>
Signed-off-by David S. Miller <[email protected]>
---
 net/ipv6/route.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
net/ipv6/route.c +3 -1
index 904312e..e7db701 100644
@@ -739,8 +739,10 @@ restart:
 
 	if (!rt->rt6i_nexthop && !(rt->rt6i_flags & RTF_NONEXTHOP))
 		nrt = rt6_alloc_cow(rt, &fl->fl6_dst, &fl->fl6_src);
-	else
+	else if (!(rt->dst.flags & DST_HOST))
 		nrt = rt6_alloc_clone(rt, &fl->fl6_dst);
+	else
+		goto out2;
 
 	dst_release(&rt->dst);
 	rt = nrt ? : net->ipv6.ip6_null_entry;
Signature · 1 line
1.7.4.1
#6 lore raw

Hi,

this patch solved the issue I reported. Applied the patch on -rc8.

Regards
//Ernst

Quoted 80 lines · David Miller

From: David Miller <[email protected]>
Date: Wed, 09 Mar 2011 19:20:12 -0800 (PST)

Quoted 6 lines

From: David Miller <[email protected]>
Date: Wed, 09 Mar 2011 15:58:18 -0800 (PST)

Quoted 3 lines

Ok, the following should address both bugs, #29252 and #30462, please give it some testing.

Quoted 7 lines
Quoted 2 lines

--------------------
ipv6: Don't create clones of nonexthop routes forever.

Nevermind, this patch has problems, I'm still debugging and trying to come up with a proper fix.

Thanks in advance for your patience.

Ok, I'm more confident in this version of the fix.  It passes all of my tests, and I've added instrumentation to make sure various cases are performing the operations the way I expect them to.

--------------------
ipv6: Don't create clones of host routes.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=29252
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=30462

In commit d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4 ("ipv6: Always clone offlink routes.") we forced the kernel to always clone offlink routes.

The reason we do that is to make sure we never bind an inetpeer to a prefixed route.

The logic turned on here has existed in the tree for many years, but was always off due to a protecting CPP define.  So perhaps it's no surprise that there is a logic bug here.

The problem is that we canot clone a route that is already a host route (ie. has DST_HOST set).  Because if we do, an identical entry already exists in the routing tree and therefore the ip6_rt_ins() call is going to fail.

This sets off a series of failures and high cpu usage, because when ip6_rt_ins() fails we loop retrying this operation a few times in order to handle a race between two threads trying to clone and insert the same host route at the same time.

Fix this by simply using the route as-is when DST_HOST is set.

Reported-by [email protected]
Reported-by Ernst Sjöstrand <[email protected]>
Signed-off-by David S. Miller <[email protected]>

---
 net/ipv6/route.c |    4 +++-

 1 files changed, 3 insertions(+), 1 deletions(-)
net/ipv6/route.c +3 -2
index 904312e..e7db701 100644
@@ -739,8 +739,10 @@ restart:
 
        if (!rt->rt6i_nexthop && !(rt->rt6i_flags & RTF_NONEXTHOP))
                nrt = rt6_alloc_cow(rt, &fl->fl6_dst, &fl->fl6_src);
-       else
+       else if (!(rt->dst.flags & DST_HOST))
                nrt = rt6_alloc_clone(rt, &fl->fl6_dst);
+       else
+               goto out2;
 
        dst_release(&rt->dst);
        rt = nrt ? : net->ipv6.ip6_null_entry;
--

1.7.4.1

maintainer
#7 lore raw

From: Ernst Sjöstrand <[email protected]>
Date: Fri, 11 Mar 2011 20:44:39 +0100

Quoted 1 line

this patch solved the issue I reported. Applied the patch on -rc8.

Thank you for testing.