Compilation fails when HEADROOM is 0

dpdk-dev [email protected] 4 participants 5 messages Jul 24, 2019 – Jul 25, 2019

Share & tools

[email protected]

author

2019-07-24 15:34 UTC #0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=335

Bug ID: 335
Summary: Compilation fails when HEADROOM is 0
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---

The compilation error:
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c:28:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed-member" [-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
make[6]: *** Waiting for unfinished jobs....
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:37:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed-member" [-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c:26:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed-member" [-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fslmc_vfio.c:40:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^

Signature · 2 lines

You are receiving this mail because:
You are the assignee for the bug.

Matan Azrad

2019-07-24 15:37 UTC #1 lore raw

Hi Hemant, Sachin

Looks like issue in dpaa.
Please check.

Quoted 81 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of [email protected]
Sent: Wednesday, July 24, 2019 6:35 PM
To: [email protected]
Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.
dpdk.org%2Fshow_bug.cgi%3Fid%3D335&data=02%7C01%7Cmatan%40 mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d9 ba6a4d149256f461b%7C0%7C0%7C636995792862104273&sdata=DrdcCJ mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&reserved=0
Bug ID: 335
Summary: Compilation fails when HEADROOM is 0
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
The compilation error:
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_dpbp.c:28:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
make[6]: *** Waiting for unfinished jobs....
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_dpio.c:37:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_dpci.c:26:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl mc_vfio.c:40:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
--
You are receiving this mail because:
You are the assignee for the bug.

Stephen Hemminger

2019-07-24 16:24 UTC #2 lore raw

Quoted 86 lines · On Wed, 24 Jul 2019 15:37:40 +0000 Matan Azrad <[email protected]> wrote:

Hi Hemant, Sachin
Looks like issue in dpaa.
Please check.
Quoted 81 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of [email protected]
Sent: Wednesday, July 24, 2019 6:35 PM
To: [email protected]
Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.
dpdk.org%2Fshow_bug.cgi%3Fid%3D335&data=02%7C01%7Cmatan%40 mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d9 ba6a4d149256f461b%7C0%7C0%7C636995792862104273&sdata=DrdcCJ mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&reserved=0
Bug ID: 335
Summary: Compilation fails when HEADROOM is 0
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
The compilation error:
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_dpbp.c:28:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
make[6]: *** Waiting for unfinished jobs....
In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_dpio.c:37:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_dpci.c:26:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from /auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl mc_vfio.c:40:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
^
--
You are receiving this mail because:
You are the assignee for the bug.

It seems reasonable for a driver to require headroom to store extra data in receive buffer. It should be documented though.

Matan Azrad

2019-07-24 16:40 UTC #3 lore raw

From: Stephen Hemminger <[email protected]>

Quoted 106 lines

Sent: Wednesday, July 24, 2019 7:24 PM
To: Matan Azrad <[email protected]>
Cc: Hemant Agrawal <[email protected]>; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
Quoted 13 lines · On Wed, 24 Jul 2019 15:37:40 +0000 Matan Azrad <[email protected]> wrote:
Hi Hemant, Sachin
Looks like issue in dpaa.
Please check.
Quoted 8 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of [email protected]
Sent: Wednesday, July 24, 2019 6:35 PM
To: [email protected]
Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
https://bugs.
dpdk.org%2Fshow_bug.cgi%3Fid%3D335&data=02%7C01%7Cmatan%40
Quoted 1 line
Quoted 1 line
mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d9
Quoted 1 line
Quoted 1 line
ba6a4d149256f461b%7C0%7C0%7C636995792862104273&sdata=DrdcCJ
Quoted 1 line
Quoted 1 line
mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&reserved=0
Quoted 15 lines
Quoted 15 lines
Bug ID: 335
Summary: Compilation fails when HEADROOM is 0
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
Quoted 3 lines
Quoted 3 lines
The compilation error:
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 2 lines
Quoted 2 lines
rtal/dpaa2_hw_dpbp.c:28:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
RTE_PKTMBUF_HEADROOM"
Quoted 9 lines
Quoted 9 lines
^
cc1: error: unrecognized command line option
"-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
make[6]: *** Waiting for unfinished jobs....
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 2 lines
Quoted 2 lines
rtal/dpaa2_hw_dpio.c:37:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
RTE_PKTMBUF_HEADROOM"
Quoted 7 lines
Quoted 7 lines
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 2 lines
Quoted 2 lines
rtal/dpaa2_hw_dpci.c:26:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
RTE_PKTMBUF_HEADROOM"
Quoted 7 lines
Quoted 7 lines
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl
Quoted 2 lines
Quoted 2 lines
mc_vfio.c:40:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
RTE_PKTMBUF_HEADROOM"

Quoted 8 lines

Quoted 5 lines
Quoted 5 lines
^
--
You are receiving this mail because:
You are the assignee for the bug.
It seems reasonable for a driver to require headroom to store extra data in receive buffer. It should be documented though.

Yes.

But if so, this driver should not be compiled by default, or change to raise run-time error instead.

What do you think?

Hemant Agrawal

2019-07-25 06:04 UTC #4 lore raw

HI Matan,

Quoted 125 lines

Quoted 8 lines
Quoted 5 lines · On Wed, 24 Jul 2019 15:37:40 +0000 Matan Azrad <[email protected]> wrote:
Hi Hemant, Sachin
Looks like issue in dpaa.
Please check.
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of [email protected]
Sent: Wednesday, July 24, 2019 6:35 PM
To: [email protected]
Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0
https://bugs.
dpdk.org%2Fshow_bug.cgi%3Fid%3D335&data=02%7C01%7Cmatan%40
Quoted 2 lines
Quoted 1 line
Quoted 1 line
mellanox.com%7Cef4c519dd7b1495178f808d7104c7400%7Ca652971c7d2e4d 9
Quoted 2 lines
Quoted 1 line
Quoted 1 line
ba6a4d149256f461b%7C0%7C0%7C636995792862104273&sdata=DrdcC J
Quoted 2 lines
Quoted 1 line
Quoted 1 line
mYUMZxk3j%2F%2BxPlqXMOAb9GDNBPzSNzpifzcMU%3D&reserved=0
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Bug ID: 335
Summary: Compilation fails when HEADROOM is 0
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
Quoted 4 lines
Quoted 3 lines
Quoted 3 lines
The compilation error:
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
rtal/dpaa2_hw_dpbp.c:28:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
Quoted 11 lines
RTE_PKTMBUF_HEADROOM"
Quoted 9 lines
Quoted 9 lines
^
cc1: error: unrecognized command line option
"-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpbp.o] Error 1
make[6]: *** Waiting for unfinished jobs....
In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
rtal/dpaa2_hw_dpio.c:37:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
Quoted 10 lines
RTE_PKTMBUF_HEADROOM"
Quoted 8 lines
Quoted 8 lines
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpio.o] Error 1 In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
rtal/dpaa2_hw_dpci.c:26:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
Quoted 10 lines
RTE_PKTMBUF_HEADROOM"
Quoted 8 lines
Quoted 8 lines
^
cc1: error: unrecognized command line option "-Wno-address-of-packed- member"
[-Werror]
cc1: all warnings being treated as errors
make[6]: *** [portal/dpaa2_hw_dpci.o] Error 1 In file included from
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/fsl
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
mc_vfio.c:40:0:
/auto/mtrswgwork/matan/reps/matan_rep/dpdk.org/drivers/bus/fslmc/po
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
rtal/dpaa2_hw_pvt.h:76:2:
error: #error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM"
#error "Annotation requirement is more than
RTE_PKTMBUF_HEADROOM"
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
^
--
You are receiving this mail because:
You are the assignee for the bug.
It seems reasonable for a driver to require headroom to store extra data in receive buffer. It should be documented though.

Quoted 6 lines

Yes.
But if so, this driver should not be compiled by default, or change to raise run-time error instead.
What do you think?

[Hemant] We will change it to run-time error.