Skip to contentSkip to conversation

New: Error-valued pointer dereferences in SCSI

Bug 34412 [email protected] 1 participant 3 messages May 4, 2011 – Aug 23, 2012 SCSI

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=34412

Summary: Error-valued pointer dereferences in SCSI
Product: SCSI Drivers
Version: 2.5
Kernel Version: 2.6.38.3
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

Created an attachment (id=56572)
--> (https://bugzilla.kernel.org/attachment.cgi?id=56572)
Complete sample traces and slices describing error-valued pointer dereferences in SCSI

We have statically analyzed SCSI, VFS and the memory management module to find error-valued pointers that are dereferenced. We have found two potential error-valued pointer dereferences:

drivers/scsi/scsi_devinfo.c:716: Dereferencing variable scsi_dev_info_add_list#devinfo_table, which may contain one of the following error codes: EINVAL*

mm/slub.c:511: Dereferencing variable check_bytes#start, which may contain one of the following error codes: ENOMEM*

For each potential error-valued pointer dereference, our tool produces a complete sample trace and a corresponding slice. The complete sample trace illustrates how one error code may reach the program point at which the variable is dereferenced. The slice summarizes the complete sample trace by including only relevant program points at which the error code is transferred from variable to variable or returned by a function. Sample traces and slices for the above error-valued pointer dereferences are attached.

Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#1 lore raw

[Bug 34412] Error-valued pointer dereferences in SCSI

https://bugzilla.kernel.org/show_bug.cgi?id=34412

Andrew Morton <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #1 from Andrew Morton <[email protected]> 2011-05-05 22:34:59 --- (In reply to comment #0)

Quoted 4 lines

drivers/scsi/scsi_devinfo.c:716: Dereferencing variable scsi_dev_info_add_list#devinfo_table, which may contain one of the following error codes: EINVAL*

This appears to be just wrong. I see no such bug in scsi_dev_info_add_list().

I suggest that you look more closely at the code which the tool is generating reports about, to identify false positives and to improve the tool.

When you have spotted some real bugs, please report them via email to [email protected]. Because hardly anyone reads bugzilla and to get a developer to look at these issues I'd have to route the reports to the linux-kernel list for you.

Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#2 lore raw

[Bug 34412] Error-valued pointer dereferences in SCSI

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=34412

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
         Resolution|                            |OBSOLETE
Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.