New: Support for building gstreamer without libxml
https://bugs.busybox.net/show_bug.cgi?id=373
Summary: Support for building gstreamer without libxml
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: will.newton at gmail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0
Created an attachment (id=375)
--> (https://bugs.busybox.net/attachment.cgi?id=375)
Add support for building gstreamer without libxml2
Hi,
This patch adds support for building gstreamer without XML enabled, which saves the space needed for libxml2 on the target. The default build behaviour should be unchanged.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
https://bugs.busybox.net/show_bug.cgi?id=373
--- Comment #1 from Sven Neumann <[email protected]> 2009-06-04 13:48:06 UTC --- Just out of interest, what functionality will be missing then?
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
--- Comment #2 from Will Newton <[email protected]> 2009-06-04 13:49:50 UTC --- At the moment plugin registry and load/save of pipelines. It should be possible to use the binary registry and just lose load/save but I'm not sure if gstreamer can be built that way yet.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
--- Comment #3 from Markus Heidelberg <[email protected]> 2009-06-04 19:12:02 UTC --- It seems to be more common to simply use something like BR2_PACKAGE_GSTREAMER_XML instead of BR2_PACKAGE_GSTREAMER_WITH_XML, i.e. without the "_WITH".
You shouldn't introduce a new variable GSTREAMER_XML_DEP, but do GSTREAMER_DEPENDENCIES += libxml2
similar to GSTREAMER_CONF_OPT +=
Having libxml2 behind host-pkgconfig doesn't matter.
In gst-plugins-good
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
--- Comment #4 from Markus Heidelberg <[email protected]> 2009-06-04 19:21:05 UTC --- In the gst-plugins-good package there is a plugin called "annodex (XML Library)". I guess it should now select BR2_PACKAGE_GSTREAMER_XML instead of BR2_PACKAGE_LIBXML2 (or both?).
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
Will Newton <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #375 is|0 |1
obsolete| |
--- Comment #5 from Will Newton <[email protected]> 2009-06-05 14:24:19 UTC --- Created an attachment (id=377)
--> (https://bugs.busybox.net/attachment.cgi?id=377)
Add support for building gstreamer without libxml2
Hopefully this takes all the comments above into account.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
--- Comment #6 from Markus Heidelberg <[email protected]> 2009-06-05 16:35:05 UTC --- (In reply to comment #5)
Quoted 1 line
Hopefully this takes all the comments above into account.
The config option name and the dependency variable cleanup, yes. But what about the annodex plugin?
Oh, and personally I like "ifeq" more than "ifneq", especially if the true condition is the default.
And while I'm nitpicking: the "enable" is superfluous, it's all about enabling and disabling in this configuration system. And I'd rather keep the description short (XML dependency) and move further information (registry ...) into a help section. But now I'll be quiet :)
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
Will Newton <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #377 is|0 |1
obsolete| |
--- Comment #7 from Will Newton <[email protected]> 2009-06-08 14:10:42 UTC --- Created an attachment (id=381)
--> (https://bugs.busybox.net/attachment.cgi?id=381)
Add support for building gstreamer without libxml2
I've tweaked it a bti further to take into account comments. I haven't added the annodex change because I'm not sure it's worth it. It would only help a user who disabled the libxml2 dependency explicitly and then selected the annodex plugin that used libxml2.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
--- Comment #8 from Markus Heidelberg <[email protected]> 2009-06-08 21:09:19 UTC --- (In reply to comment #7)
Quoted 1 line
Created an attachment (id=381)
--> (https://bugs.busybox.net/attachment.cgi?id=381) [details]
Quoted 7 lines
Add support for building gstreamer without libxml2
I've tweaked it a bti further to take into account comments. I haven't added the annodex change because I'm not sure it's worth it. It would only help a user who disabled the libxml2 dependency explicitly and then selected the annodex plugin that used libxml2.
I wasn't sure about the annodex plugin myself, that's why I wrote "I guess ...". Given that BR2_PACKAGE_GSTREAMER_LIBXML2 can be seen as an option to disable registry and load/save with the side effect that libxml2 is not a dependency anymore, I guess annodex doesn't have to be adjusted.
So I'm fine with this.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 373] Support for building gstreamer without libxml
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=373
Peter Korsgaard <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED--- Comment #9 from Peter Korsgaard <[email protected]> 2009-06-18 09:01:22 UTC --- Thanks, fixed in git
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.