New: No support for DGE-530T Rev C1

Bugme-new Andrew Morton 3 participants 4 messages Jul 6, 2011 1 message not in the archive

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Andrew Morton

author

2011-07-06 21:37 UTC #1 lore raw

In reply to a message not in the archive

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).

Quoted 30 lines · On Wed, 6 Jul 2011 16:05:36 GMT [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=38862
           Summary: No support for DGE-530T Rev C1
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.39.2
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Network
        AssignedTo: [email protected]
        ReportedBy: [email protected]
        Regression: No
The kernel support DGE-530T REV B2 through the skge driver. The PCI device id of REV-B2 is 1186:4302. Rev C1 has a PCI device id of 1186:4302. No driver in the current kernel supports this device id/vendor combination. Furthermore, this device is not even listed in the device database ->
http://www.pcidatabase.com/vendor_details.php?id=921 .
On the chip is the following information:
D-Link
DLG10028C
A8A34A1
GA50 TAIWAN

Quoted 5 lines

A sticker on the card reads:
DGE-530T Rev C1
I am including a picture I took of the card.

Did you test simply adding that device to the driver?

drivers/net/skge.c renamed from drivers/net/skge.c~a +1 -0

@@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },

James Henderson

2011-07-06 21:54 UTC #2 lore raw

Quoted 56 lines · Andrew Morton

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 30 lines · On Wed, 6 Jul 2011 16:05:36 GMT [email protected] wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=38862
           Summary: No support for DGE-530T Rev C1
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.39.2
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Network
        AssignedTo: [email protected]
        ReportedBy: [email protected]
        Regression: No
The kernel support DGE-530T REV B2 through the skge driver. The PCI device id of REV-B2 is 1186:4302. Rev C1 has a PCI device id of 1186:4302. No driver in the current kernel supports this device id/vendor combination. Furthermore, this device is not even listed in the device database ->
http://www.pcidatabase.com/vendor_details.php?id=921 .
On the chip is the following information:
D-Link
DLG10028C
A8A34A1
GA50 TAIWAN
Quoted 6 lines
A sticker on the card reads:
DGE-530T Rev C1
I am including a picture I took of the card.
Did you test simply adding that device to the driver?
drivers/net/skge.c renamed from drivers/net/skge.c~a +1 -0
@@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },

Quoted 3 lines

_

No I haven't tested that change - I don't have a kernel development environment setup and unfortunately I don't have any more work time to budget to the issue beyond reporting it.

Also, I meant to say that Rev B2 has PCI id 1186:4B01 (although you seem to have figured that out).

Thanks,

James

Andrew Morton

author

2011-07-06 21:54 UTC #3 lore raw

Quoted 19 lines · On Wed, 6 Jul 2011 17:48:44 -0400 James Henderson…

Quoted 12 lines
Did you test simply adding that device to the driver?
drivers/net/skge.c renamed from drivers/net/skge.c~a +1 -0
@@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
Quoted 3 lines
_
No I haven't tested that change - I don't have a kernel development environment setup and unfortunately I don't have any more work time to budget to the issue beyond reporting it.

Quoted 2 lines

Also, I meant to say that Rev B2 has PCI id 1186:4B01 (although you seem to have figured that out).

OK, I suppose we can add that info thusly:

drivers/net/skge.c renamed from drivers/net/skge.c~drivers-net-skgec-support-dlink-dge-530t-rev-c1 +2 -1

@@ -88,7 +88,8 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_GE) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T Rev B2 */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },

although that might be misleading if, say, 0x4b01 describes other revisions.

But there isn't much we can do with this until someone can test the change.

Stephen Hemminger

2011-07-06 22:08 UTC #4 lore raw

In reply to James Henderson

Quoted 47 lines · On Wed, 6 Jul 2011 17:48:44 -0400 James Henderson…

Quoted 46 lines · Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface).
Quoted 30 lines · On Wed, 6 Jul 2011 16:05:36 GMT [email protected] wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=38862
           Summary: No support for DGE-530T Rev C1
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.39.2
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Network
        AssignedTo: [email protected]
        ReportedBy: [email protected]
        Regression: No
The kernel support DGE-530T REV B2 through the skge driver. The PCI device id of REV-B2 is 1186:4302. Rev C1 has a PCI device id of 1186:4302. No driver in the current kernel supports this device id/vendor combination. Furthermore, this device is not even listed in the device database ->
http://www.pcidatabase.com/vendor_details.php?id=921 .
On the chip is the following information:
D-Link
DLG10028C
A8A34A1
GA50 TAIWAN
Quoted 6 lines
A sticker on the card reads:
DGE-530T Rev C1
I am including a picture I took of the card.
Did you test simply adding that device to the driver?

Quoted 11 lines

drivers/net/skge.c renamed from drivers/net/skge.c~a +1 -0

@@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },

I will go look at the Marvell Syskonnect driver, they occasionally up date it with new ID's.