New: Grub fails to install bz2 patch after conversion to AUTOTARGETS

https://bugs.busybox.net/show_bug.cgi?id=4093

Build: buildroot-20110725
Summary: Grub fails to install bz2 patch after conversion to
AUTOTARGETS
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P3
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: cloak at theblackroom.ca
CC: buildroot at uclibc.org
Estimated Hours: 0.0

After the patch :
grub: convert to AUTOTARGETS
committed on

   2011-07-10 13:28:23 (GMT)

the grub package no longer applies all the patches in boot/grub, specifially the grub.400-nic_update2.patch.bz2.

The following line was removed from grub.mk:
toolchain/patch-kernel.sh $(GRUB_DIR) boot/grub grub.\*.patch{,.bz2}

This handled application of the bz2 patch, and the new autotargets conversion calls toolchain/patch-kernel.sh with grub*.patch grub*.patch.{ARCH} as the script parameters. There is no ability for autotargets to use compressed patch files.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=4093

--- Comment #1 from Chris <[email protected]> --- After a proper patch of boot/grub/grub.400-nic_update2.patch.bz2, boot/grub/grub.500-build-fix.patch is not needed.

I submitted this as a bug as I don't know the best way to fix it, but as a work around, I just bunzip2'd grub.400-nic_update2.patch.bz2 and autotargets picked up the patch as expected.

I imagine the proper fix will be to have the autotargets infrastructure be able to use compressed patches.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=4093

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Peter Korsgaard <[email protected]> --- Thanks, fixed in git by expanding the 400 patch and getting rid of the 500 like you suggested as well. We're very close to the 2011.08 release, so I don't want to add compressed patch support to ATOTARGETS atm.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.