Skip to contentSkip to conversation

New: kvm module has bogus kernel version check

Bug 42812 [email protected] 1 participant 4 messages Feb 22, 2012 – May 12, 2012 KVM

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=42812

Summary: kvm module has bogus kernel version check
Product: Virtualization
Version: unspecified
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: kvm
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

In kvm-kmod-3.2, x86/external-module-compat.h, line 1102 the following check is present:

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) || \
    (LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) && KERNEL_EXTRAVERSION < 40)

The second half is bogus, since if kernel version is 2.6.32, it would have matched the < 2.6.37 anyway.
Maybe the 2,6,32 should read 2,6,37 instead? (that would make more sense, but may not be right!)

This check appears to be present since kvm-kmod release 3.0b, which makes it unlikely many people tried it with 2.6.27.40+ kernels and found it to be a problem...

--
Maarten

Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#1 lore raw

[Bug 42812] kvm module has bogus kernel version check

https://bugzilla.kernel.org/show_bug.cgi?id=42812

Jan Kiszka <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #1 from Jan Kiszka <[email protected]> 2012-02-28 17:29:13 --- Thanks for reporting, addressed in latest kvm-kmod.git.

Jan

Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#2 lore raw

[Bug 42812] kvm module has bogus kernel version check

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=42812

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
         Resolution|                            |CODE_FIX
Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#3 lore raw

[Bug 42812] kvm module has bogus kernel version check

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=42812

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED

Signature · 3 lines
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.