Skip to contentSkip to conversation

New: prevent patch commands from accessing source control

Buildroot bugzilla at busybox.net 1 participant 2 messages Oct 22, 2011 – Nov 26, 2011

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=4357

Summary: prevent patch commands from accessing source control
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: d_mo1234 at yahoo.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0

Created attachment 3655
--> https://bugs.busybox.net/attachment.cgi?id=3655
patch file

A little while back, I ran into a problem compiling buildroot on an older Ubuntu (9.xx I think), where patch was attempting to perform Perforce source control operations. We had to fix this by adding -g0 to the patch script. I think this may not be a problem on newer distributions, but perhaps it would be good to ensure that patch doesn't attempt such ops in the future by using the -g0.

The line that we fixed is in apply-patches.sh, but I noticed that there is also a patch command in grub.mk too. I have attached a patch for both.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#1 lore raw

[Buildroot] [Bug 4357] prevent patch commands from accessing source control

https://bugs.busybox.net/show_bug.cgi?id=4357

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Peter Korsgaard <[email protected]> 2011-11-26 20:57:29 UTC --- Committed, thanks

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.