Skip to contentSkip to conversation

Capture of sound from USB connected audio card (UGM96) doesn't work in 3.5.1 - kernel bug generated: scheduling while atomic

Bug 46011 Daniel Mack 3 participants 3 messages Aug 16, 2012 – Aug 17, 2012 4 messages not in the archive

lore
Share & tools
lore
#4 lore raw
In reply to a message not in the archive
Quoted 1 line · Takashi Iwai
Quoted 1 line
Quoted 1 line

Could you try the patch below?

Clemens, the patch below fixes a "sleeping while atomic" bug in the USB audio driver, but it raises a new "not enough bandwidth" issue, which might even be unreleated.

I currently don't see the root cause here, but I might be blind. Do you have any idea?

Thanks,
Daniel

Quoted 53 lines

---
From: Takashi Iwai <[email protected]>
Subject: [PATCH] ALSA: usb-audio: Fix scheduling-while-atomic bug in PCM
capture stream

A PCM capture stream on usb-audio causes a scheduling-while-atomic BUG, as reported in the bugzilla entry below. It's because snd_usb_endpoint_start() is called at first at trigger START for a capture stream, and this function contains the left-over EP deactivation codes. The problem doesn't happen for a playback stream because the function is called at PCM prepare time, which can sleep.

This patch fixes the BUG by moving the EP deactivation code into the PCM prepare callback.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46011

---
 sound/usb/endpoint.c | 4 ----
 sound/usb/pcm.c      | 3 +++
 2 files changed, 3 insertions(+), 4 deletions(-)
sound/usb/endpoint.c +0 -4
index 0f647d2..c411812 100644
@@ -821,10 +821,6 @@ int snd_usb_endpoint_start(struct snd_usb_endpoint *ep)
 	if (++ep->use_count != 1)
 		return 0;
 
-	/* just to be sure */
-	deactivate_urbs(ep, 0, 1);
-	wait_clear_urbs(ep);
-
 	ep->active_mask = 0;
 	ep->unlink_mask = 0;
 	ep->phase = 0;
sound/usb/pcm.c +3 -0
index a1298f3..62ec808 100644
@@ -544,6 +544,9 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
 	subs->last_frame_number = 0;
 	runtime->delay = 0;
 
+	/* clear the pending deactivation on the target EPs */
+	deactivate_endpoints(subs);
+
 	/* for playback, submit the URBs now; otherwise, the first hwptr_done
 	 * updates for all URBs would happen at the same time when starting */
 	if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK)
#5 lore raw
Quoted 9 lines · Daniel Mack

Clemens, the patch below fixes a "sleeping while atomic" bug in the USB audio driver, but it raises a new "not enough bandwidth" issue, which might even be unreleated.

Review static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream) · line 546

Quoted 5 lines

+++ b/sound/usb/pcm.c

(quoted diff) +2 -0
@@ -544,6 +544,9 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
 
+	/* clear the pending deactivation on the target EPs */
+	deactivate_endpoints(subs);

The HC drivers calculate bandwidth for a stream when the first URB is submitted or the last one is completed. (xHCI does this when the altsetting is changed; IIRC there are plans to have other HCDs do the same.)

This patch doesn't change the relative order of URB submissions and cancellations. The descriptions in bug 46011 indicates that we're running into the not-completely-fixed EHCI scheduling bugs.

Regards,
Clemens

#6 lore raw

At Thu, 16 Aug 2012 13:26:48 +0200,

Quoted 17 lines · Clemens Ladisch
Quoted 9 lines · Daniel Mack

Clemens, the patch below fixes a "sleeping while atomic" bug in the USB audio driver, but it raises a new "not enough bandwidth" issue, which might even be unreleated.

Review static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream) · line 546

Quoted 5 lines

+++ b/sound/usb/pcm.c

(quoted diff) +2 -0
@@ -544,6 +544,9 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
 
+	/* clear the pending deactivation on the target EPs */
+	deactivate_endpoints(subs);

The HC drivers calculate bandwidth for a stream when the first URB is submitted or the last one is completed. (xHCI does this when the altsetting is changed; IIRC there are plans to have other HCDs do the same.)

Quoted 3 lines

This patch doesn't change the relative order of URB submissions and cancellations. The descriptions in bug 46011 indicates that we're running into the not-completely-fixed EHCI scheduling bugs.

Yes, this reminds me of a known issue...

In anyway, the fix for the bad EP deactivation was already merged to sound git tree and will be included in the next pull request for 3.6-rc3.

Takashi