New: dropbear Makefile broken
https://bugs.busybox.net/show_bug.cgi?id=5378
Summary: dropbear Makefile broken
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: arved at arved.at
CC: buildroot at uclibc.org
Estimated Hours: 0.0
Under some circumstances dropbear 2012.55 adds -lcrypt to the OBJS variable
Instead -lcrypt should be added to LIBS
Patch attached
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5378] dropbear Makefile broken
https://bugs.busybox.net/show_bug.cgi?id=5378
--- Comment #1 from Tilman Keskin?z <[email protected]> 2012-07-19 12:22:22 UTC --- Created attachment 4430
--> https://bugs.busybox.net/attachment.cgi?id=4430
Don't add -lcrypu to OBJS
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5378] dropbear Makefile broken
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=5378
--- Comment #2 from Thomas Petazzoni <[email protected]> 2012-08-21 12:04:35 UTC --- What problem is this solving exactly?
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5378] dropbear Makefile broken
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=5378
--- Comment #3 from Tilman Keskin?z <[email protected]> 2012-09-10 11:05:46 UTC --- The build of the dropbear package was failing, because there was no rule to create "-lcrypt" obj.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5378] dropbear Makefile broken
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=5378
--- Comment #4 from Peter Korsgaard <[email protected]> 2012-09-10 19:53:16 UTC --- (In reply to comment #3)
Quoted 2 lines
The build of the dropbear package was failing, because there was no rule to create "-lcrypt" obj.
Hmm, I don't seem to be able to reproduce this. Could you provide more details about your config, please?
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5378] dropbear Makefile broken
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=5378
--- Comment #5 from Mike Frysinger <[email protected]> 2012-09-10 20:05:14 UTC --- (In reply to comment #1)
it would be better to fix Makefile.in itself and then send the fix upstream
(In reply to comment #2)
make has implicit rules to handle "-lfoo" in its dependency list. so dropbear does this:
dropbearobjs=$(COMMONOBJS) $(CLISVROBJS) $(SVROBJS) @CRYPTLIB@
...
dropbear: $(dropbearobjs)
this expands into:
dropbear: ... -lcrypt
and make executes its implicit code to try and find /usr/lib/libcrypt.a. if you don't have that, it'll fail.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5378] dropbear Makefile broken
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=5378
--- Comment #6 from Peter Korsgaard <[email protected]> 2012-09-10 20:52:39 UTC --- (In reply to comment #5)
Quoted 13 lines
(In reply to comment #1)
it would be better to fix Makefile.in itself and then send the fix upstream
(In reply to comment #2)
make has implicit rules to handle "-lfoo" in its dependency list. so dropbear does this:
dropbearobjs=$(COMMONOBJS) $(CLISVROBJS) $(SVROBJS) @CRYPTLIB@
...
dropbear: $(dropbearobjs)
Quoted 5 lines
this expands into:
dropbear: ... -lcryptand make executes its implicit code to try and find
/usr/lib/libcrypt.a. if you don't have that, it'll fail.
Ahh yes, I missed that.
And yes, I agree with Mike. Please fix it correctly (E.G. in Makefile.in) and submit upstream.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5378] dropbear Makefile broken
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=5378
Gustavo Zacarias <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WONTFIX--- Comment #7 from Gustavo Zacarias <[email protected]> 2013-12-11 17:16:47 UTC --- Upstream bug, please submit your patch to them.
Thanks.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.