Skip to contentSkip to conversation

shutdown_api/test_change_thresholds: Port config all rxpt, rxht, rxwt are invalid

dpdk-dev [email protected] 1 participant 2 messages Oct 14, 2020 – Jan 29, 2021

lore
Share & tools
lore

[email protected]

author Reviewed-by Ferruh Yigit
#0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=554

Bug ID: 554
Summary: shutdown_api/test_change_thresholds: Port config all
rxpt, rxht, rxwt are invalid
Product: DPDK
Version: 20.11
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: testpmd
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---

Created attachment 124
--> https://bugs.dpdk.org/attachment.cgi?id=124&action=edit
shutdown_api/test_change_thresholds-FAILED-log

Environment:
•DPDK version: 20.11.0-rc0 commit 700ded7aa15f5ecc5b68d12fcb6fd3bfe06e599d •OS: CentOS8.2/4.18.0-193.6.3.el8_2.x86_64
•Compiler: gcc 8.3.1
•Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz •NIC hardware: 82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb •NIC firmware: 0x000161bf
•NIC driver version: 5.1.0-k-rh8.2.0

Steps to reproduce:
1. Bind 2 PFs to vfio-pci.
#dpdk-devbind.py --force --bind=vfio-pci 0000:81:00.0 0000:81:00.1
2. Launch testpmd.
#x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2 -n 4 -w 0000:81:00.0 -w 0000:81:00.1 --file-prefix=dpdk_10376_20201015182508 -- -i --portmask=0x1 --port-topology=loop
testpmd> set promisc all off
testpmd> port stop all
testpmd> port config all rxpt 64
testpmd> port config all rxht 64
testpmd> port config all rxwt 64
testpmd> port start all
testpmd> show config rxtx

Actual Result:
port 0: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x0
RX queue: 0
RX desc=256 - RX free threshold=32
RX threshold registers: pthresh=0 hthresh=0 wthresh=0 RX Offloads=0x0
TX queue: 0
TX desc=256 - TX free threshold=32
TX threshold registers: pthresh=64 hthresh=64 wthresh=0 TX offloads=0x0 - TX RS bit threshold=32
port 1: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x0
RX queue: 0
RX desc=256 - RX free threshold=32
RX threshold registers: pthresh=0 hthresh=0 wthresh=0 RX Offloads=0x0
TX queue: 0
TX desc=256 - TX free threshold=32
TX threshold registers: pthresh=64 hthresh=64 wthresh=0 TX offloads=0x0 - TX RS bit threshold=32

Expected Result:
port 0: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x0
RX queue: 0
RX desc=256 - RX free threshold=32
RX threshold registers: pthresh=64 hthresh=64 wthresh=64 RX Offloads=0x0
TX queue: 0
TX desc=256 - TX free threshold=32
TX threshold registers: pthresh=64 hthresh=64 wthresh=0 TX offloads=0x0 - TX RS bit threshold=32
port 1: RX queue number: 1 Tx queue number: 1
Rx offloads=0x0 Tx offloads=0x0
RX queue: 0
RX desc=256 - RX free threshold=32
RX threshold registers: pthresh=64 hthresh=64 wthresh=64 RX Offloads=0x0
TX queue: 0
TX desc=256 - TX free threshold=32
TX threshold registers: pthresh=64 hthresh=64 wthresh=0 TX offloads=0x0 - TX RS bit threshold=32

Regression:
Is this issue a regression: Y
First bad commit:
commit 700ded7aa15f5ecc5b68d12fcb6fd3bfe06e599d (HEAD -> master)

Author: Huisong Li <[email protected]>
Date:   Fri Sep 25 20:47:19 2020 +0800

app/testpmd: fix displaying Rx/Tx queues information

Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "ports[pid].tx_conf" maintained in testpmd application may be not the value actually used by PMD driver. For instance, user does not set a field, but PMD driver has to use the default value.

This patch fixes rxtx_config_display so that the information of Rx/Tx queues can be really displayed for the PMD driver that implement .rxq_info_get and .txq_info_get ops callback function.

Fixes 75c530c1bd53 ("app/testpmd: fix port configuration print")
Fixes d44f8a485f5d ("app/testpmd: enable per queue configure")
Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.
#1 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=554

Zhang, RobinX ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |WONTFIX
                 CC|                            |[email protected]
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Zhang, RobinX ([email protected]) --- 82599 NIC not support this feature on rx.

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.