Skip to contentSkip to conversation

scsi/be2iscsi/be_main.c:328: possible bad if expression ?

Bug 67091 [email protected] 2 participants 2 messages Dec 18, 2013 – Dec 19, 2013 1 message not in the archive

Subsystems (2)
SCSI Emulex 10Gbps iSCSI - OneConnect driver
lore
Share & tools
lore

[email protected]

author
#1 lore raw
In reply to a message not in the archive

https://bugzilla.kernel.org/show_bug.cgi?id=67091

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

                 CC|                            |[email protected]
          Component|Other                       |Other
           Assignee|[email protected] |scsi_drivers-other@kernel-b
                   |sdl.org                     |ugs.osdl.org
            Product|Drivers                     |SCSI Drivers
Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#2 lore raw
Quoted 4 lines · On 12/18/2013 08:24 AM, [email protected] wrote:

https://bugzilla.kernel.org/show_bug.cgi?id=67091

Alan <[email protected]> changed:

Quoted 8 lines

What |Removed |Added
----------------------------------------------------------------------------

                 CC|                            |[email protected]
          Component|Other                       |Other
           Assignee|[email protected] |scsi_drivers-other@kernel-b
                   |sdl.org                     |ugs.osdl.org
            Product|Drivers                     |SCSI Drivers

Jay,

I thought we fixed that bug. I am not seeing a patch though. I think we wanted to be checking against the sc passed in. Patch is compile tested only.

drivers/scsi/be2iscsi/be_main.c +1 -1
index 1f37505..5642a9b 100644
@@ -325,7 +325,7 @@ static int beiscsi_eh_device_reset(struct scsi_cmnd *sc)
 		if (!abrt_task->sc || abrt_task->state == ISCSI_TASK_FREE)
 			continue;
 
-		if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
+		if (sc->device->lun != abrt_task->sc->device->lun)
 			continue;
 
 		/* Invalidate WRB Posted for this Task */