New: SDL-dfb does not select directfb
https://bugs.busybox.net/show_bug.cgi?id=683
Summary: SDL-dfb does not select directfb
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Keywords: patch
Severity: normal
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: damien.courousse.logica at gmail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0
Hello,
I got a compilation error with SDL-dfb selected while directfb was not selected. The compilation reported something like:
(...)
o./src/video/directfb/SDL_DirectFB_events.c:32:22: error: directfb.h: No such file or directory
In file included from ./src/video/directfb/SDL_DirectFB_events.c:38:./src/video/directfb/SDL_DirectFB_video.h:40: error: expected specifier-qualifier-list before 'IDirectFB' ./src/video/directfb/SDL_DirectFB_video.h:60: error: expected declaration specifiers or '...' before 'DFBResult' ./src/video/directfb/SDL_DirectFB_events.c:43: error: expected ')' before '*' token./src/video/directfb/SDL_DirectFB_events.c:44: error: expected ')' before '*' token./src/video/directfb/SDL_DirectFB_events.c: In function 'DirectFB_PumpEvents':./src/video/directfb/SDL_DirectFB_events.c:51: error: 'DFBInputEvent' undeclared (first use in this function) ./src/video/directfb/SDL_DirectFB_events.c:51: error: (Each undeclared identifier is reported only once ./src/video/directfb/SDL_DirectFB_events.c:51: error: for each function it appears in.)./src/video/directfb/SDL_DirectFB_events.c:51: error: expected ';' before 'evt' ./src/video/directfb/SDL_DirectFB_events.c:53: error: 'struct SDL_PrivateVideoData' has no member named 'eventbuffer' ./src/video/directfb/SDL_DirectFB_events.c:53: error: 'struct SDL_PrivateVideoData' has no member named 'eventbuffer' ./src/video/directfb/SDL_DirectFB_events.c:54: error: 'evt' undeclared (first use in this function) ./src/video/directfb/SDL_DirectFB_events.c:54: error: 'DFB_OK' undeclared (first use in this function) ./src/video/directfb/SDL_DirectFB_events.c:60: error: 'DIET_BUTTONPRESS' undeclared (first use in this function) ./src/video/directfb/SDL_DirectFB_events.c:64: error: 'DIET_BUTTONRELEASE' undeclared (first use in this function) ./src/video/directfb/SDL_DirectFB_events.c:68: error: 'DIET_KEYPRESS' undeclared (first use in this function)
(...)
Hence I think BR2_PACKAGE_SDL_DIRECTFB should select BR2_PACKAGE_DIRECTFB :
package/sdl/Config.in +1 -0
@@ -13,6 +13,7 @@ config BR2_PACKAGE_SDL_FBCON config BR2_PACKAGE_SDL_DIRECTFB bool "SDL DirectFB video driver" + select BR2_PACKAGE_DIRECTFB config BR2_PACKAGE_SDL_QTOPIA bool "SDL Qtopia video driver"
Cheers,
Damien
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 683] SDL-dfb does not select directfb
https://bugs.busybox.net/show_bug.cgi?id=683
--- Comment #1 from Thomas Petazzoni <[email protected]> 2009-10-27 16:01:49 UTC --- Thanks Damien for reporting the issue.
I'm wondering whether we should use a select as you suggested, or a depends on. We usually use "select" so that the user doesn't need to care about missing dependencies. But in the case of DirectFB, many things can (and should ?) be configured at the DirectFB level, so I'm not sure that selecting DirectFB behind the user's back is good.
something like:
config BR2_PACKAGE_SDL_DIRECTFB
bool "SDL DirectFB video driver"
+ depends on BR2_PACKAGE_DIRECTFB
+ comment "sdl-dfb requires directfb support"
+ depends on !BR2_PACKAGE_DIRECTFB
Peter, your opinion on this ?
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 683] SDL-dfb does not select directfb
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=683
--- Comment #2 from Peter Korsgaard <[email protected]> 2009-10-27 16:28:28 UTC --- (In reply to comment #1)
Quoted 17 lines
Thanks Damien for reporting the issue.
I'm wondering whether we should use a select as you suggested, or a depends on. We usually use "select" so that the user doesn't need to care about missing dependencies. But in the case of DirectFB, many things can (and should ?) be configured at the DirectFB level, so I'm not sure that selecting DirectFB behind the user's back is good.
something like:
config
BR2_PACKAGE_SDL_DIRECTFB
bool "SDL DirectFB video driver"(quoted diff) +3
-0+ depends on BR2_PACKAGE_DIRECTFB + comment "sdl-dfb requires directfb support" + depends on !BR2_PACKAGE_DIRECTFB
Quoted 1 line
Peter, your opinion on this ?
We should imho use depends on (and also for the qt/x11 backends) similar to how it is done for E.G. libgtk2.
Notice that the dependencies in the makefile are likewise missing.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 683] SDL-dfb does not select directfb
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=683
Peter Korsgaard <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED--- Comment #3 from Peter Korsgaard <[email protected]> 2009-11-22 20:04:47 UTC --- Thanks, fixed in git (351b67960)
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.