New: mutex_unlock is missed in function (swap_inode_boot_loader) in file (linux-3.13/fs/ext4/ioctl.c)
https://bugzilla.kernel.org/show_bug.cgi?id=70091
Bug ID: 70091
Summary: mutex_unlock is missed in function
(swap_inode_boot_loader) in file (linux-3.13/fs/ext4/ioctl.c)
Product: File System
Version: 2.5
Kernel Version: 3.13
Hardware: x86-64
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: ext4
Assignee: [email protected]
Reporter: [email protected]
Regression: No
In function (swap_inode_boot_loader) in file (linux-3.13/fs/ext4/ioctl.c):
The structures: (inode->i_mutex) and (inode_bl->i_mutex) gets successfully locked at line (133) by (lock_two_nondirectories(inode, inode_bl), but both are not unlocked when the function returns after line (147), however they got unlocked only at line (208) by (unlock_two_nondirectories(inode, inode_bl)).
A possible solution is to call (unlock_two_nondirectories(inode, inode_bl)) before line (147).
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.
[Bug 70091] mutex_unlock is missed in function (swap_inode_boot_loader) in file (linux-3.13/fs/ext4/ioctl.c)
https://bugzilla.kernel.org/show_bug.cgi?id=70091
Conrad Meyer <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #1 from Conrad Meyer <[email protected]> --- This was fixed in 30d29b119ef01776e0a301444ab24defe8d8bef3
Author: Zheng Liu <[email protected]> Date: Wed Feb 12 11:48:31 2014 -0500
ext4: fix error paths in swap_inode_boot_loader()
In swap_inode_boot_loader() we forgot to release ->i_mutex and resume unlocked dio for inode and inode_bl if there is an error starting the journal handle. This commit fixes this issue.
In merge commit 805937cf45f9a9933e6b8e5c6660406e977a9a23
Author: Linus Torvalds <[email protected]> Date: Tue Feb 18 10:04:09 2014 -0800
Merge tag 'ext4_for_linus_stable' ofgit://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
...
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.
[Bug 70091] mutex_unlock is missed in function (swap_inode_boot_loader) in file (linux-3.13/fs/ext4/ioctl.c)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=70091
Theodore Tso <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |[email protected]
Resolution|--- |CODE_FIX--- Comment #2 from Theodore Tso <[email protected]> --- Thanks for the note!
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.