Skip to contentSkip to conversation

New: Git dl of versions in x/y broken

Buildroot bugzilla at busybox.net 1 participant 9 messages Aug 19, 2014 – Aug 25, 2014

lore
Share & tools
lore

bugzilla at busybox.net

author
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=7328

Summary: Git dl of versions in x/y broken
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: vincent.stehle at freescale.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0

Latest buildroot (1) will not download git versions in x/y properly. Instead, it will try to download x_y.

This was working fine with an old commit (2).

After bisecting, it seems that commit 54456cc6982598fa45e7c97609e83fabec7c1695 broke it.

Best regards,

V.

(1) latest commit f67e7ba06f5f00dc9153ad364932092692458704
(2) old commit 249464674485ed1fa18a2d0dd5500c84198490b9

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#1 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

https://bugs.busybox.net/show_bug.cgi?id=7328

--- Comment #1 from Thomas De Schampheleire <[email protected]> 2014-08-19 16:23:53 UTC --- Please be more specific: what do you mean with 'in x/y' ?
Please give an example and/or a reproduction scenario.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#2 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=7328

--- Comment #2 from Vincent Stehl? <[email protected]> 2014-08-19 16:27:16 UTC --- (In reply to comment #1)

Quoted 1 line

Please be more specific: what do you mean with 'in x/y' ?

In my case I set <PKG>_VERSION in a .mk to my development branch:

FOO_VERSION = vincent/dev

Quoted 1 line

Please give an example and/or a reproduction scenario.

I'll try to devise a quick test case with a public git tree to demonstrate.

V.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#3 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=7328

--- Comment #3 from Vincent Stehl? <[email protected]> 2014-08-19 16:38:34 UTC --- (In reply to comment #2)

Quoted 1 line

Please give an example and/or a reproduction scenario.

Ok, here is a quick test case to demonstrate the issue:

In package/dtc/dtc.mk, change:

DTC_VERSION = refs/tags/v1.4.0

Then do:

make defconfig
make dtc-source

This works on 249464674485ed1fa18a2d0dd5500c84198490b9, but not after 54456cc6982598fa45e7c97609e83fabec7c1695.

V.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#4 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=7328

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |ASSIGNED
                 CC|                            |yann.morin.1998 at free.fr
         AssignedTo|unassigned at buildroot.uclibc |yann.morin.1998 at free.fr
                   |.org                        |

--- Comment #4 from Yann E. MORIN <[email protected]> 2014-08-19 16:44:46 UTC --- Confirmed.

Here is a tentative patch to ifix the issue.

Signed-off-by "Yann E. MORIN" <[email protected]>
package/pkg-generic.mk +0 -0
index fb4b849..d04fd36 100644
@@ -318,14 +318,14 @@ $(2)_RAWNAME            =  $$(patsubst host-%,%,$(1))
 # version control system branch or tag, for example

remotes/origin/1_10_stable.
ifndef $(2)_VERSION
ifdef $(3)_VERSION
- $(2)_DL_VERSION = $$($(3)_VERSION)
+ $(2)_DL_VERSION := $$($(3)_VERSION)
$(2)_VERSION := $$(subst /,_,$$($(3)_VERSION))
else
$(2)_VERSION = undefined
$(2)_DL_VERSION = undefined
endif
else
- $(2)_DL_VERSION = $$($(2)_VERSION)
+ $(2)_DL_VERSION := $$($(2)_VERSION)
$(2)_VERSION := $$(subst /,_,$$($(2)_VERSION))
endif

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#5 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=7328

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

           Priority|P5                          |P1
   Target Milestone|---                         |2014.08
           Severity|minor                       |major
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#6 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=7328

--- Comment #5 from Vincent Stehl? <[email protected]> 2014-08-19 16:57:22 UTC --- (In reply to comment #4)

Quoted 1 line

Here is a tentative patch to ifix the issue.

This patch repairs my builds.

Thank you very much, Yann!

V

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#7 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=7328

--- Comment #6 from Yann E. MORIN <[email protected]> 2014-08-19 17:32:41 UTC --- Patch sent to the list:

    http://patchwork.ozlabs.org/patch/381411/
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
author
#8 lore raw

[Buildroot] [Bug 7328] Git dl of versions in x/y broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=7328

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Peter Korsgaard <[email protected]> 2014-08-25 22:46:17 UTC --- Fixed by Yann in 1939011ce6f5cf, thanks

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.