New: make interactive CLI optional for nftables

https://bugs.busybox.net/show_bug.cgi?id=7556

Summary: make interactive CLI optional for nftables
Product: buildroot
Version: 2014.08
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: alex at digriz.org.uk
CC: buildroot at uclibc.org
Estimated Hours: 0.0

Created attachment 5744
--> https://bugs.busybox.net/attachment.cgi?id=5744
patch to make nftables cli optional

nftables requires readline (and thus in turn ncurses) which adds considerably to the size of the root filesystem (~500kB for MIPS).

Did a bit of work and we can now make it optional (by default it is not enabled).

Is this patch reasonable, need me to do anything else to it for it to be considered for buildroot. I am also reaching out to the nftables team to see about upstreaming this.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=7556

--- Comment #1 from Thomas Petazzoni <[email protected]> 2014-10-26 18:06:33 UTC --- Since this is really a feature patch, we generally prefer to not have it in Buildroot. Can you instead send your patch to the nftables maintainers, and
then once accepted, send the appropriate patch to Buildroot?

By the way, we prefer to see patches posted on the mailing list. See
http://buildroot.org/downloads/manual/manual.html#submitting-patches for details.

Thanks a lot!

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=7556

--- Comment #2 from Alexander Clouter <[email protected]> 2014-12-06 19:28:26 UTC --- Looks like someone has beaten me to it:

http://marc.info/?l=netfilter-devel&m=141288774531750&w=2

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=7556

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #3 from Thomas Petazzoni <[email protected]> 2014-12-06 20:23:58 UTC --- (In reply to comment #2)

Thanks for following up on this. So you know have several options:

1/ Wait for upstream to make a new release, and once this is done, send a
patch to Buildroot to update to the latest version.

2/ Send a patch right now to update Buildroot to the latest Git version of
nftables, and then later send a patch to do (1) once an upstream release is made.

3/ Send a patch to Buildroot that adds the patch you pointed in
package/nftables/, after having backported it to the version of nftables currently used in Buildroot.

If you can't wait, (2) is probably the easiest option.

Since this bug really isn't a bug, but more a feature request about an upstream package rather than Buildroot itself, I'll mark it as "invalid". Please don't take this as a "we don't care" message: we are definitely looking forward for your patches on this topic, as being able to disable readline support is definitely useful.

Thanks!

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.