Skip to contentSkip to conversation

KNI request overwritten with new asynchronous kni_net_release mechanism

dpdk-dev [email protected] 1 participant 1 message Sep 14, 2021

lore
Share & tools
lore
#0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=809

            Bug ID: 809
           Summary: KNI request overwritten with new asynchronous
                    kni_net_release mechanism
           Product: DPDK
           Version: 21.11
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

With the new asynchronous KNI request for kni_net_release() there is a potential for an interface down request to be overwritten in the KNI request fifo. The issue occurs when an application sets an interface down, immediately followed by setting the interface up.

The down request gets put on the KNI fifo and then returns immediately (inside kni_net_process_request) . If a subsequent up request comes in before the down request has had a chance to be processed by the request handler, the new up request gets written to the same KNI sync address, thus overwriting the down request and the first down request will be missed:

/* Construct data */

        memcpy(kni->sync_kva, req, sizeof(struct rte_kni_request)); <--
Overwritten
        num = kni_fifo_put(kni->req_q, &kni->sync_va, 1);

Before this asynchronous mechanism was introduced this was prevented by taking the kni->sync_lock and waiting for the response. But even in this case if the wait timeout was exceeded, this same type of condition could theoretically happen.

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.