Skip to contentSkip to conversation

Uninitialized value of devargs.bus_str for RTE_DEVARGS_KEY_CLASS case

dpdk-dev [email protected] 1 participant 2 messages Oct 28, 2021 – Nov 4, 2021

lore
Share & tools
lore
#0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=862

            Bug ID: 862
           Summary: Uninitialized value of devargs.bus_str  for
                    RTE_DEVARGS_KEY_CLASS case
           Product: DPDK
           Version: 21.11
          Hardware: All
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: other
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

In the 21.11_rc2 code base there are some changes in the function rte_devargs_layers_parse (in the lib/eal/common/eal_common_devargs.c) due to these changes an issue got introduced which is resulting junk value for 'devargs.bus_str' in the function rte_dev_iterator_init for RTE_DEVARGS_KEY_CLASS case.

- Earlier devargs->bus_str was getting populated for all the cases of RTE_DEVARGS_KEY_*(_CLASS/_BUS/_DRIVER) in the rte_devargs_layers_parse.

- In the latest code it is getting populated only for RTE_DEVARGS_KEY_BUS so for all other cases it has junk value for 'devargs.bus_str' if devargs fields are NOT set to 0 by caller function.

- rte_dev_iterator_init is calling rte_devargs_layers_parse() and it does not set devargs fields to 0 before passing it to rte_devargs_layers_parse so for RTE_DEVARGS_KEY_CLASS case devargs->bus_str is having junk value which is causing issue.
- When running dpdk-vdpa app then it is unable to find vDPA device Due to this issue.

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.
#1 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=862

David Marchand ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|IN_PROGRESS                 |RESOLVED
                 CC|                            |[email protected]
         Resolution|---                         |FIXED

--- Comment #4 from David Marchand ([email protected]) --- There was a fix already posted by Xueming, see:
https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/

Fixed with: https://git.dpdk.org/dpdk/commit/?id=fc382022c6ad

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.