New: xdriver_xf86-input-mouse install header files in target directory

https://bugs.busybox.net/show_bug.cgi?id=8696

Bug ID: 8696
Summary: xdriver_xf86-input-mouse install header files in
target directory
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: buildroot at netsolux.ch
CC: buildroot at uclibc.org
Target Milestone: ---

Hello,

xdriver_xf86-input-mouse package install evdev-properties.h and xf86-mouse-properties.h in output/target/data/buildroot/output/host/usr/arm-buildroot-linux-gnueabihf/sysroot/usr/include/xorg.

[root at devel linux]$ ls -lsa /data/buildroot/output/target/data/buildroot/output/host/usr/arm-buildroot-linux-gnueabihf/sysroot/usr/include/xorg/ total 16
4 drwxr-xr-x 2 root root 4096 Feb 15 00:01 .
4 drwxr-xr-x 3 root root 4096 Feb 15 00:01 ..
4 -rw-r--r-- 1 root root 3585 Feb 15 00:01 evdev-properties.h
4 -rw-r--r-- 1 root root 1489 Feb 15 00:01 xf86-mouse-properties.h

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #1 from Thomas Petazzoni <[email protected]> ---
Your path output/target/data/buildroot/output/host/usr/arm-buildroot-linux-gnueabihf/sysroot/usr/include/xorg looks really wrong.

Why do you have Buildroot itself inside an output/target/data directory ?

Or maybe output/target/data just happens to be the place where you store the Buildroot sources ?

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #2 from buildroot at netsolux.ch --- /data/buildroot is the place where I store the buildroot sources

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #3 from buildroot at netsolux.ch --- Something like https://bugs.busybox.net/show_bug.cgi?id=8441

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at buildroot.uclibc |gustavo at zacarias.com.ar
|.org |

--- Comment #4 from Thomas Petazzoni <[email protected]> --- I am indeed able to reproduce the problem:

target/home/test/outputs/xorg/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/xorg/xf86-mouse-properties.h

This is due to the value returned as sdkdir by pkg-config. Gustavo, you patched pkg-config and it handles sdkdir specially. Do you know what's going on here?

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

                 CC|                            |yann.morin.1998 at free.fr
             Status|NEW                         |ASSIGNED

--- Comment #5 from Yann E. MORIN <[email protected]> --- Yes, this has been the case for a long time now.

I even had a patch series to fix that once and for all:

    http://lists.busybox.net/pipermail/buildroot/2015-November/143562.html

But it was dismissed in favour of Gustavoz' pkg-conf fixups. However, that series did not completely fix the Xorg weirdness, but since it was not causing regressions (i.e. the bad paths were prsent before and after), the pkg-conf fixes were applied, and my series got forgotten.

I'll respin that in a moment...

Regards,
Yann E. MORIN.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #6 from Thomas Petazzoni <[email protected]> --- Gustavo, Yann, any news?

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #7 from Yann E. MORIN <[email protected]> --- Fixed with:

    http://lists.busybox.net/pipermail/buildroot/2016-March/155859.html

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|gustavo at zacarias.com.ar |yann.morin.1998 at free.fr

--- Comment #8 from Yann E. MORIN <[email protected]> --- Hello,

I've given that issue another spin, and we still have three xorg packages that still install headers in target/ :
- xdriver_xf86-input-synaptics
- xdriver_xf86-input-joystick
- xdriver_xf86-input-mouse

I'll see how to fix them...

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #9 from Yann E. MORIN <[email protected]> --- Hello again,

So, two other packages are affected:
- xdriver_xf86-input-evdev
- xdriver_xf86-input-libinput

I managed to fix the first one rather easily, and its headers are now installed in the correct location.

However, since all those input drivers are not slated for being installed in staging/ , the headers are only in target/ (but are properly cleaned up in target-finalize).

One question remains: are those headeerrs supposed to be used by external applications? If so, then the packages must also be installed in staging (once they are all fixed to get rid of sdkdir).

Care to give a bit of feedback on my question above, please?

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #10 from Yann E. MORIN <[email protected]> --- Created attachment 6776
--> https://bugs.busybox.net/attachment.cgi?id=6776&action=edit
Tentative patch for evdev only

Hello,

Can you please test this patch? Thanks!

Regards,
Yann E. MORIN.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

--- Comment #11 from Yann E. MORIN <[email protected]> --- Hello,

I just sent a series to fix this issue:

    http://lists.busybox.net/pipermail/buildroot/2016-October/175496.html

Please give it a spin, and see if it fixes it for you.

Please, can you also reply to my question in comment #9?

Regards,
Yann E. MORIN.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=8696

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #12 from Thomas Petazzoni <[email protected]> --- Fixed by the following commits:

b63951da35f56a2c606b9383e6e39bfd61e92b34 package/xdriver_xf86-input-synaptics:
fix install paths
3065189a0a64cd3382a67115b2119d773e02e697 package/xdriver_xf86-input-mouse: fix install paths
b8bd2bea3b1ce2cdb0c510e2aee889ae9b3f2c92 package/xdriver_xf86-input-libinput:
fix install paths
e07338fa99f7807fafd32dc6b811d313bd14327b package/xdriver_xf86-input-joystick:
fix install paths
df8534455472b4257d57b88162a8fb8402fc50ff package/xdriver_xf86-input-evdev: fix install paths

Thanks Yann for providing those patches!

You are receiving this mail because:
You are on the CC list for the bug.