New: Error on support/download/git with system git older than 1.8.4

https://bugs.busybox.net/show_bug.cgi?id=9101

Bug ID: 9101
Summary: Error on support/download/git with system git older
than 1.8.4
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: eocanha at igalia.com
CC: buildroot at uclibc.org
Target Milestone: ---

Created attachment 6556
--> https://bugs.busybox.net/attachment.cgi?id=6556&action=edit
Proposed patch

A recent commit[1] in the git downloader uses the "--no-patch" option, which appeared on git 1.8.4. Systems with older git versions show an error and fall back to the wget downloader, which isn't suitable for all the cases.

I'm attaching a one-line patch which uses a "git log" variant and works on older systems.

[1]
https://github.com/buildroot/buildroot/commit/3abd5ba4243489b821d44e407528020cd8a138f8#diff-75410bcfefacf16bcd60a2a6ac77c433R73

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9101

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

                 CC|                            |yann.morin.1998 at free.fr
             Status|NEW                         |ASSIGNED

--- Comment #1 from Yann E. MORIN <[email protected]> --- Enrique, All,

Ok, good catch. I'm OK with the patch.

Could you please send it to the list? See our manual:
https://buildroot.org/downloads/manual/manual.html#submitting-patches

(All the reviews on patches happen on the list, not in the tracker).

Thanks!

Regards,
Yann E. MORIN.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9101

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at buildroot.uclibc |yann.morin.1998 at free.fr
|.org |

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9101

--- Comment #2 from Matt Weber <[email protected]> --- Sent in the following patch based on Enrique's attachment. Thanks!

https://patchwork.ozlabs.org/patch/653473/

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9101

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Thomas Petazzoni <[email protected]> --- Fixed in commit 1e39f0873393189278d92ac3589a329f42c8311c.

You are receiving this mail because:
You are on the CC list for the bug.