New: Missing overlays directory in VFAT image for raspberry pi 3

https://bugs.busybox.net/show_bug.cgi?id=9166

Bug ID: 9166
Summary: Missing overlays directory in VFAT image for raspberry
pi 3
Product: buildroot
Version: 2016.05
Hardware: Other
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: diez.roggisch at ableton.com
CC: buildroot at uclibc.org
Target Milestone: ---

When running a raspberry pi 3 buildroot, dtoverlay-parameters (e.g. dtoverlay=pi3-disable-bt) don't work, because the VFAT image doesn't contain the overlays-subdirectory.

The following patch fixes this.

b/board/raspberrypi/genimage-raspberrypi3.cfg
index 7ba89c5..baab0c4 100644

@@ -7,6 +7,7 @@ image boot.vfat {
       "rpi-firmware/config.txt",
       "rpi-firmware/fixup.dat",
       "rpi-firmware/start.elf",
+      "rpi-firmware/overlays",
       "kernel-marked/zImage"
     }
   }

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9166

diez.roggisch at ableton.com changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from diez.roggisch at ableton.com ---
I found that BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS actually does the job - but only after a clean rebuild. I will close.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9166

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|RESOLVED                    |CLOSED
                 CC|                            |yann.morin.1998 at free.fr
         Resolution|FIXED                       |WORKSFORME

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9166

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|WORKSFORME |INVALID

--- Comment #2 from Yann E. MORIN <[email protected]> --- Diez,

If you found that your bug was in fact not resolved and still valid, you should have reopenned it rather than sending an email to an individual.

Indeed, that is not the case.

The defconfig files we provide in Buildroot are "minimalist" configs, aimed at building the strict minimum to get a board to actually boot up to a shell prompt, with wired networkingv (no wireless). No more.

This is because there are so many possibilities to use a board that we will definitely never be able to cover all use cases. At least, a minimal defconfig gets the board booting and ready to use in its basic setup. It is a known-working starting point for further customisation by the user.

In your casse, edit (or copy then edit) the genimage-raspberrypi3.cfg to suit your needs.

I'll keep this report closed, however, because I believe the behaviour you reported is what is intended.

Feel free to comment, though. ;-)

Regards,
Yann E. MORIN.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9166

--- Comment #3 from diez.roggisch at ableton.com ---
First, my apologies for violating the unknown protocol. Won't happen again.

I checked, and matter of factly the patch would break buildroot if BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS was not selected. So it's moot anyway.

I still would like a solution that takes care of this semi-automatically, as it's simply surprising for a developer IMHO. But I will argue for that once (and if) I find one.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9166

--- Comment #4 from Yann E. MORIN <[email protected]> --- Diez,

I was not suggesting that you submit a patch to Buildroot, but that you handle the customisation on your side. Use your own genimage.cfg file that suits your need.

The manual has a section on how to handle local customisations:
https://buildroot.org/downloads/manual/manual.html#customize

One would argue that overlays are very often used so they should be installed by our defconfigs.

However, there are so many overlays, for so different things, that usually only one or a few would be needed in a specific case. Or even that overlays from anotehr place are used.

So I am still not sure we want to have our defconfigs install the overlays.

Regards,
Yann E. MORIN.

You are receiving this mail because:
You are on the CC list for the bug.