New: sis190 network driver crash
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]/
Quoted 28 lines · On Thu, 15 Nov 2007 07:30:53 -0800 (PST) [email protected] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=9386
Summary: sis190 network driver crash Product: Drivers Version: 2.5 KernelVersion: 2.6.23.1 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Network AssignedTo: [email protected] ReportedBy: [email protected] CC: [email protected]I have a problem where I can lock up a number of machines by changing the link state on a sis190 Ethernet port. For example, during a data transfer such as FTP if I unplug the Ethernet cable and plug it back in, the Ethernet interface will stop responding and the machine will lock up after a minute or so. This behaviour is repeatable. I have the sis190 driver loaded as a module.
I haven't found a kernel version where this doesn't happen. It happens with kernel 2.6.20.15, for example.
David Miller
maintainerFrom: Andrew Morton <[email protected]>
Date: Thu, 15 Nov 2007 11:58:41 -0800
Quoted 3 lines · On Thu, 15 Nov 2007 07:30:53 -0800 (PST) [email protected] wrote:
Quoted 2 lines
...
Quoted 9 lines
Quoted 9 lines
I have a problem where I can lock up a number of machines by changing the link state on a sis190 Ethernet port. For example, during a data transfer such as FTP if I unplug the Ethernet cable and plug it back in, the Ethernet interface will stop responding and the machine will lock up after a minute or so. This behaviour is repeatable. I have the sis190 driver loaded as a module.
I haven't found a kernel version where this doesn't happen. It happens with kernel 2.6.20.15, for example.
I wonder if somehow sis190_phy_task() is creating some kind of deadlock when handling the link down and up events.
It takes the RTNL semaphore in sis190_phy_task() but it doesn't call anything which can see deadlocking on that.
It does invoke the link-watch layer, indirectly via the various netif_carrier_{on,off}() calls it makes but those should be OK since they just schedule workqueue things.
Perhaps what is contributing to the problem is that sis190_interrupt() still processes the RX and TX queues even when a link change event is signalled. Perhaps the chip doesn't like that.
Francois, I noticed two issues while reviewing the driver for this bug:
1) The interrupt handler does no SMP locking, the chip might not be happy with one thread (in phy_task) programming the MDIO whilst another thread does RX/TX ring processing, for example.
2) The timeout limit check in __mdio_cmd() is buggy, it should be 99 instead of 999.
David Miller <[email protected]> :
[...]
Quoted 2 lines
I wonder if somehow
sis190_phy_task()is creating some kind of deadlock when handling the link down and up events.
I should be able to test it during the week end if nobody beats me
The sis190 stands headless in the kitchen. Given the current situation here, I do not have the oomph to turn the kitchen into a debug lab when I am back from work.
Signature · 1 line
Ueimor