Skip to contentSkip to conversation

New: triggerhappy: systemd unit broken

Buildroot bugzilla at busybox.net 1 participant 5 messages Apr 26, 2017 – May 8, 2017

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=9836

Bug ID: 9836
Summary: triggerhappy: systemd unit broken
Product: buildroot
Version: 2017.02.1
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: posted at heine.so
CC: buildroot at uclibc.org
Target Milestone: ---

I'm using triggerhappy in combination with systemd and a bash based system (no busybox).

The systemd unit fails with this error message:

"Error opening '/dev/input/event*': No such file or directory"

The systemd unit has the start command defined as follows:

ExecStart=/usr/sbin/thd --triggers /etc/triggerhappy/triggers.d --socket /var/run/thd.socket --user nobody /dev/input/event*

If you run the command directly from bash it is working, I guess because bash is already expanding the wildcard.

thd started supporting Wildcards in Version 0.5.0. with the option "--deviceglob" [1]

before it proposed a wrapper script for the systemd unit added in this commit:
[2]

I don't know if the unit currently supplied with buildroot ever worked, but not with the thd version currently used.

Since 0.5.0 the systemd unit should be like this: [3]

So I could supply a patch but I'm not sure what is preferable. Fix the systemd unit supplied with the current version included in buildroot 2017.02.1. Or bump the version and provide the new style unit?

Regards,
Michael

[1]https://github.com/wertarbyte/triggerhappy/commit/c9b6556bd45529eebfabcad3b843beb185aca5fc [2]https://github.com/wertarbyte/triggerhappy/commit/47a9e4e842676c48d056aefe623af1d29a9b0e5e [3]https://github.com/wertarbyte/triggerhappy/commit/06720d2305bedc7fcef8b18919f5c73a73164f85

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
#1 lore raw

[Buildroot] [Bug 9836] triggerhappy: systemd unit broken

https://bugs.busybox.net/show_bug.cgi?id=9836

--- Comment #1 from Thomas Petazzoni <[email protected]> --- (In reply to Michael Heinemann from comment #0)

Thanks for your detailed report! I'd say bump the version and use the new unit is most likely the right option here.

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
#2 lore raw

[Buildroot] [Bug 9836] triggerhappy: systemd unit broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=9836

Michael Heinemann <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |posted at heine.so

--- Comment #2 from Michael Heinemann <[email protected]> --- Created attachment 7046
--> https://bugs.busybox.net/attachment.cgi?id=7046&action=edit
patch to bump version to 0.5.0

Proposed fix to bump version and fix systemd unit

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
#3 lore raw

[Buildroot] [Bug 9836] triggerhappy: systemd unit broken

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=9836

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Thomas Petazzoni <[email protected]> --- Thanks, I've applied your patch as of
https://git.buildroot.org/buildroot/commit/?id=3e23b1c9bb74bf1edf3f71d5c1e6e5e364e0821a.

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.