New: lz4 option does not install lz4 binaries in ramdisk

https://bugs.busybox.net/show_bug.cgi?id=9996

Bug ID: 9996
Summary: lz4 option does not install lz4 binaries in ramdisk
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: jamin.collins at gmail.com
CC: buildroot at uclibc.org
Target Milestone: ---

Selecting the lz4 option in the menuconfig does not result in the lz4 binaries being installed into the ramdisk, only the libraries. This appears to be due to a problem in the package's makefile. The following change corrects this:

$ git diff

index d350d4c09..4a7129998 100644
@@ -37,7 +37,7 @@ endef
 
 define LZ4_INSTALL_TARGET_CMDS
        $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE)

DESTDIR=$(TARGET_DIR) \
- PREFIX=/usr install -C $(@D)/lib
+ PREFIX=/usr install -C $(@D)
endef

$(eval $(generic-package))

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9996

Arnout Vandecappelle <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

            Summary|lz4 option does not install |lz4 package does not
                   |lz4 binaries in ramdisk     |install lz4 binaries in
                   |                            |target

--- Comment #1 from Arnout Vandecappelle <[email protected]> ---
This was done by commit 8ad38a4fc2007df4bee9a941aed46c8771b6a84c by Gabe Evans. It's a simple version bump, the commit message mentions nothing of this change:

package/lz4: bump version to r131

systemd v228 requires lz4 >= 125

[Thomas: only pass PREFIX=/usr at install time instead of using LZ4_MAKE_OPTS, and also pass it for the host installation.]

So I guess it was an accident. Gabe, can you comment?

Jamin, could you send the patch (with a proper commit message and a Signed-off-by) to the Buildroot mailing list so we can retain your authorship?

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9996

--- Comment #2 from Thomas Petazzoni <[email protected]> --- I just submitted a patch fixing this:
http://patchwork.ozlabs.org/patch/858601/.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=9996

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Peter Korsgaard <[email protected]> --- Fixed by
https://git.buildroot.org/buildroot/commit/?id=6f1c11f79a64387c1f1749550804f8aae0cfa7a7,
thanks

You are receiving this mail because:
You are on the CC list for the bug.