Skip to contentSkip to conversation

lib: Move setup_ipc() to the beginning of do_setup()

PATCH zhaogongyi via ltp 1 participant 1 message Oct 20, 2022

lore
Share & tools
lore
#0 lore raw

Hi,

Quoted 20 lines

Hello,

Quoted 15 lines · Zhao Gongyi via ltp

Move setup_ipc() to the beginning of do_setup() since we would use the 'results' immediately in do_setup(), otherwise,there is no Results statistics when calling the tst_brk in do_setup().

---
 lib/tst_test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/tst_test.c index renamed from lib/tst_test.c +0 -0

8ccde1629..02fc6a06e 100644

lib/tst_test.c +0 -0
@@ -1096,6 +1096,8 @@ static void do_cgroup_requires(void)
 
Quoted 5 lines

lib/tst_test.c static void do_cgroup_requires(void) · line 1099

Quoted 3 lines
lib/tst_test.c +2 -0
 static void do_setup(int argc, char *argv[])  {
+	setup_ipc();
+

We can't move it to before checking if tst_test is null.

Actrually, tst_test is not null for ever since we have a definition at lint 375 in tst_test.h:

static struct tst_test test;

So, is there any problem exist that I did not see?

Regards,
Gongyi

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp